Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Co-authored-by: abernier <76580+abernier@users.noreply.github.com>
Co-authored-by: abernier <76580+abernier@users.noreply.github.com>
Co-authored-by: abernier <76580+abernier@users.noreply.github.com>
Co-authored-by: abernier <76580+abernier@users.noreply.github.com>
| { | ||
| "$schema": "https://unpkg.com/@changesets/config@3.0.2/schema.json", | ||
| "changelog": "@changesets/cli/changelog", | ||
| "commit": false, |
There was a problem hiding this comment.
@copilot why commit false
i had it true in abernier/react-mcu
There was a problem hiding this comment.
Updated to "commit": true in 25efd68 to match the react-mcu reference. This will auto-commit changeset files when running yarn changeset.
Co-authored-by: abernier <76580+abernier@users.noreply.github.com>
|
@copilot what do you have to say to #2607 (review)? |
I'm unable to access the specific review at that link. Could you please share the feedback or questions from that review directly here? Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
Changesets have been seriously problematic and were removed from r3f. I dont think this is the path going forward. I saw it was a copilot thing so maybe just an experiment, reopen if you disagree and we can all talk about it |
|
i disagree, changeset is way more powerful and decoupled from git it also support monorepos semantic-release has also its downsides, really and just a draft PR |
I've had nothing but issues with them and @krispya and I were so annoyed with them we removed them from R3F. Most dev teams dont know how to use them, they dont seem to store the changelog well and cause more confusion than I'd like. But maybe I just suck with them, I know @isaac-mason loves them too... |
|
@DennisSmolek I have also fallen a bit out of love with them. I once really liked using changesets for handling publishing in monorepos with multiple packages. But I stopped doing that, and life became simpler 😄 For a project with other contributors, most importantly, I always ended up having to add changesets to other people's PRs anyway. Not much of a time saver! |
|
For me it always adds friction. Enforcing PRs for updates does everything I need to manage and audit releases. |
|
are we now discussing about removing semantic-release too? 😅 Challenging the interest of an automated semver-releasing tool like, Semantic-release or Changesets are, wasn't the goal of this PR initially We greatly benefited from Semantic-release for drei (@drcmda pushed for it). This PR was only a draft, trying to harmonise Drei with the rest of pmndrs/* libs which are mosltly using Changesets |
|
I think semantic-release is good for Drei since it rarely has a single maintainer. |
No not at all IMO semantic-release is solid.
That was the point I was trying to make and discuss is that many of those are likely moving away from changesets too because we all have had friction with them. Seeing Isaac say the same thing kinda seals the deal in my mind that changesets aren't the way to go but I wanted to hear what others are feeling. |
|
changesets is an important tool when dealing with a monorepo with independent packages, that has inner-deps that should be chain-bumped, CHANGELOGs... etc. (all Lerna was doing before changesets superseeds it) i like it is less-coupled to git @bbohlender is also using it |
|
What is the benefit you think there would be in this repo specifically? It is certain the burden would call on maintainers to make the changelogs and there is no monorepo. |
|
publishing independent packages would allow us to actually DO semver we are actually faking it: we bump major sometimes, but not related to each components breaking changes |
|
Yeah this is a problem. I am interested in a proposal personally, something that lets people have ownership over specific domains. Maybe that is a monorepo? |
Migration from semantic-release to changesets
Based on the reference repository (react-mcu), the following changes have been made:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.