Jake's 2nd last pull#815
Open
jakehirschallen wants to merge 2 commits into
Open
Conversation
GlenWeyl
requested changes
Mar 24, 2024
GlenWeyl
left a comment
GlenWeyl
left a comment
Contributor
There was a problem hiding this comment.
This has conflicts and has come after the deadline, so will be community reviewed. As such, to receive credit you'll need to file and get funded an issue in Gov4Git/GitRules that this then resolves.
Contributor
Author
|
Will do. Sorry for the delay and thanks
Envoyé by Jake Hirsch-Allen from +16472629202
…________________________________
From: Glen Weyl ***@***.***>
Sent: Sunday, March 24, 2024 2:58:34 PM
To: pluralitybook/plurality ***@***.***>
Cc: jakehirschallen ***@***.***>; Author ***@***.***>
Subject: Re: [pluralitybook/plurality] Jake's 2nd last pull (PR #815)
@GlenWeyl requested changes on this pull request.
This has conflicts and has come after the deadline, so will be community reviewed. As such, to receive credit you'll need to file and get funded an issue in Gov4Git/GitRules that this then resolves.
—
Reply to this email directly, view it on GitHub<#815 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAILL6AWOR7H3VY33RCROQ3YZ4O5VAVCNFSM6AAAAABFFWSQ4KVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNJWGYZDSNJUGE>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Edits up to line 135 with some of the intl affairs contributions but more to make if there is time