A bunch of fixes and performance improvements#43
Merged
Conversation
Also added optional useWebWorker setting for the flexbox plugin. This will load the yoga library in a web worker and do the calculations on the worker. At this moment, the postMessage command is too slow and will require some more work, but you may get some performance gains from offloading the calculations.
Removed effects and replaced with shaders since lightning v3 removes effects Improved diff code and performance Improved focus performance Improved RN performance .. and other performance improvements
WillsonHaw
commented
Jun 27, 2025
| @@ -0,0 +1,935 @@ | |||
| diff --git a/dist/src/core/CoreNode.js b/dist/src/core/CoreNode.js | |||
Contributor
Author
There was a problem hiding this comment.
This patch is only necessary until this commit lands in v3 beta: lightning-js/renderer@3cffb58
Bumping it causes linking issues with our RN client app
Remove the patch that's no longer needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A first pass of improving a bunch of performance things. This is especially helpful for node creation, and helps improve loading speed of various screens and components.