fix: Setting renderSceneColorMap or renderSceneDepthMap to true when already set, sets it to false#8731
Open
MAG-AdrianMeredith wants to merge 1 commit into
Conversation
…already set, sets it to false
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a logic bug in CameraComponent's renderSceneColorMap and renderSceneDepthMap setters where setting the value to true while it was already requested would incorrectly disable the map. The condition is updated to only release the request when value is falsy.
Changes:
- Add
!value &&guard to theelse ifbranch in therenderSceneColorMapsetter. - Add
!value &&guard to theelse ifbranch in therenderSceneDepthMapsetter.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting renderSceneColorMap or renderSceneDepthMap to true when already set, sets it to false
Description
I don't have a proveable issue here but I saw this function and it sounds dodgy af. Passing true can cause it to set it to false, it seems unlikely to be intentional
Fixes #
n/a
Checklist