Require course in review - #45
Open
nsandler1 wants to merge 8 commits into
Open
Conversation
Contributor
|
as discussed, blocking until we have an automated course scraper we're confident is 100% correct. It would be unfortunate to merge this and have users unable to submit reviews because we don't have the course they took scraped yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once this PR is merged, users will be required to either select/input a course in their review. This change is beneficial because I believe that a course-less review is equivalent to not leaving a review in the first place. Our users want information pertaining to a professor for a particular course so why not ensure they get that.
Unfortunately we won't be able to modify all course-less reviews from our database because we're not mind readers. This means
Review.coursewill remain nullable at the model level, but at the validation level, empty course fields won't be accepted.