Skip to content

Fix for issue #206 Global OL defaultSymbolizer assignment in WMSStylesDialog creates conflicts#215

Open
justb4 wants to merge 78 commits intoplanetfederal:masterfrom
justb4:master
Open

Fix for issue #206 Global OL defaultSymbolizer assignment in WMSStylesDialog creates conflicts#215
justb4 wants to merge 78 commits intoplanetfederal:masterfrom
justb4:master

Conversation

@justb4
Copy link
Copy Markdown
Contributor

@justb4 justb4 commented Oct 30, 2013

Although issue #206 has been closed, I would like you to reconsider, also taken into the account the fix in the commits (the second is to undo a change in WFSProtocolProxy that went in by accident).

As I see it:

  • the original code changes a global var: OpenLayers.Renderer.defaultSymbolizer. This affects not only OLEditor but any other component that uses the defaultSymbolizer
  • by changing the name into OpenLayers.Renderer.defaultSymbolizerGXP (see commit) and using it in all assignments for defaults in GXP, IMO the SLD defaults are respected

justb4 added 30 commits October 30, 2013 16:21
…s-browser, fixes IE-problem in ColorField
justb4 and others added 30 commits September 16, 2014 17:35
CatalogueSearchPanel - Metadata popup window in IE doesn't show scrollbars
Same as for OLE, Add Croatian translation. Lijep ti dan želim! :-)
Add Overviewmap control to gxp
@dracic thanks for your hard work! Fix StylesDialog localization error & add missing strings for gxp
and pulled in! Fix hr.js
@deduikertjes bedankt! Goed dat dit ook configureerbaar is. Added config zoomToLayer
Fix some i18n quirks in the AddLayers.js module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants