Skip to content

strict な tsconfig パッケージの作成 #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
akameco wants to merge 10 commits into
base: main
Choose a base branch
from
Open

strict な tsconfig パッケージの作成 #9

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2eda1e5
feat: add pnpm workspace configuration
akameco Feb 26, 2026
911e03a
feat: add @plainbrew/tsconfig strict TypeScript configuration package
akameco Feb 26, 2026
69e1d85
fix: remove verbatimModuleSyntax from strict tsconfig
akameco Feb 26, 2026
43c3520
refactor: improve tsconfig based on major OSS review
akameco Feb 26, 2026
89ade92
docs: add design decisions document for tsconfig package
akameco Feb 26, 2026
595dfc3
feat: add typescript peer dependency to tsconfig package
akameco Feb 26, 2026
92a5a8a
docs: add tsconfig reference links to design decisions
akameco Feb 26, 2026
a064927
fix: update lockfile for tsconfig peerDependencies
akameco Feb 26, 2026
f3e671f
fix: require TypeScript >=5.8.0 for erasableSyntaxOnly support
akameco Feb 26, 2026
92ccc12
fix: update lockfile for typescript peerDependencies bump
akameco Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions packages/tsconfig/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
{
"name": "@plainbrew/tsconfig",
"version": "0.1.0",
"description": "Strict TypeScript configuration for plainbrew projects",
"keywords": [
"react",
"strict",
"tsconfig",
"typescript"
],
"license": "MIT",
"files": [
"tsconfig.json",
"react.json"
],
"type": "module",
"exports": {
".": "./tsconfig.json",
"./react": "./react.json"
}
Comment thread
coderabbitai[bot] marked this conversation as resolved.
}
Comment thread
coderabbitai[bot] marked this conversation as resolved.
8 changes: 8 additions & 0 deletions packages/tsconfig/react.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"$schema": "https://json.schemastore.org/tsconfig",
"extends": "./tsconfig.json",
"compilerOptions": {
"jsx": "react-jsx",
"lib": ["dom", "dom.iterable", "esnext"]
}
}
26 changes: 26 additions & 0 deletions packages/tsconfig/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
{
"$schema": "https://json.schemastore.org/tsconfig",
"compilerOptions": {
"strict": true,
"exactOptionalPropertyTypes": true,
"noFallthroughCasesInSwitch": true,
"noImplicitOverride": true,
"noImplicitReturns": true,
"noPropertyAccessFromIndexSignature": true,
"noUncheckedIndexedAccess": true,
"noUnusedLocals": true,
"noUnusedParameters": true,
"allowUnusedLabels": false,
"allowUnreachableCode": false,
"isolatedModules": true,
"esModuleInterop": true,

@akameco akameco Feb 26, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claudeより: verbatimModuleSyntax と esModuleInterop の併用は冗長。verbatimModuleSyntax: true を採用しているなら esModuleInteropは削除を検討。

@akameco akameco Feb 26, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://zenn.dev/teppeis/articles/2023-04-typescript-5_0-verbatim-module-syntax

@akameco akameco Feb 26, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これら問題は、verbatimModuleSyntaxを有効化しなくても、ESLint で@typescript-eslint/consistent-type-imports と @typescript-eslint/no-import-type-side-effects を有効化することでほとんど解決できる。auto-fix も効くし、どの環境でも特にデメリットはない？と思うのでとりあえずこれらを有効化しておくのが良さそう。

@akameco akameco Feb 26, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next.js は SWC を使用して構文を最適化するため、このオプションを true にして構文をそのまま渡すことが推奨されます。
https://zenn.dev/hayato94087/books/b174f8b1cd80db/viewer/v00-05-16-kj8s5o8gppf5#next.js-%E3%81%AB%E3%81%8A%E3%81%91%E3%82%8B%E8%A8%AD%E5%AE%9A

は〜〜

"skipLibCheck": true,
"forceConsistentCasingInFileNames": true,
"moduleResolution": "bundler",
"module": "preserve",
"resolveJsonModule": true,
"declaration": true,
"declarationMap": true,
"sourceMap": true
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated
}
}
2 changes: 2 additions & 0 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions pnpm-workspace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
packages:
- "packages/*"