Pin golangci-lint version for local and CI runs - #1069
Merged
Merged
Conversation
rck
reviewed
Sep 30, 2026
rck
left a comment
rck
left a comment
Member
There was a problem hiding this comment.
Two suggestions on the Makefile, both verified locally: guard against an empty version (which the installer reads as "latest"), and fetch the install script at the pinned tag instead of HEAD.
CI used whatever golangci-lint release was latest, while the pre-commit hook used the binary from the developer's PATH, so results could drift. Pin the version in .golangci-lint-version, which the GitHub action reads via version-file. Locally, "make lint" installs that exact release to bin/ and the pre-commit hook now runs it. Pin v2.12.2, the newest release built with Go 1.26. Later releases are built with Go 1.27, and their bundled gofumpt formats code differently than go fmt from the Go version in go.mod. Signed-off-by: Moritz Tanner <moritz.tanner@linbit.com>
WanzenBug
force-pushed
the
pin-golangci-lint
branch
from
September 30, 2026 08:43
be37d91 to
9cf6fc0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI used whatever golangci-lint release was latest, while the pre-commit hook used the binary from the developer's PATH, so results could drift.
Pin the version in .golangci-lint-version, which the GitHub action reads via version-file. Locally, "make lint" installs that exact release to bin/ and the pre-commit hook now runs it.
Pin v2.12.2, the newest release built with Go 1.26. Later releases are built with Go 1.27, and their bundled gofumpt formats code differently than go fmt from the Go version in go.mod.