Delay own-node quorum taint by fail-over timeout - #149
Merged
Merged
Conversation
Freshly created DRBD resources briefly report no quorum before their first connection is established. ManageOwnTaints immediately tainted the local node in that state, only to remove the taint again on the next run, causing unnecessary churn. Track when a resource was first seen without quorum and only count it towards the taint once it stayed in that state for the fail-over timeout, mirroring the grace period the fail-over reconciler already applies before tainting remote nodes. Signed-off-by: Moritz Tanner <moritz.tanner@linbit.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Freshly created DRBD resources briefly report no quorum before their first connection is established. ManageOwnTaints immediately tainted the local node in that state, only to remove the taint again on the next run, causing unnecessary churn.
Track when a resource was first seen without quorum and only count it towards the taint once it stayed in that state for the fail-over timeout, mirroring the grace period the fail-over reconciler already applies before tainting remote nodes.