Repository navigation
feat(assistant): float the panel without blocking the page - #763
Merged
piotrkantorowicz merged 1 commit intoOct 31, 2026
Conversation
Open the assistant as a non-modal dialog: no overlay, outside clicks keep it open, Escape and the close button dismiss it. From sm up it is a compact card in the bottom-right corner; phones keep the full-screen sheet. Closes #762
piotrkantorowicz
merged commit Oct 31, 2026
d52ba1a
into
epic/634-in-app-assistant-mcp-tools-v3
14 checks passed
piotrkantorowicz
added a commit
that referenced
this pull request
Nov 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The assistant opens as a non-modal floating window instead of a modal side sheet. No backdrop, the page behind it stays usable, outside clicks keep it open; Escape and the close button dismiss it. From
smup it is a compact card in the bottom-right corner (w-96, up to 40rem / 85dvh tall). Phones keep the full-screen sheet.Why
With the modal sheet you could not look at a page and ask about it at the same time. Design:
docs/design/assistant/README.md§9.Tests
verify.sh --staged— ui format, lint, type-check, vitest, build all passReview notes
AssistantPanel.tsxchanges (modal={false}+onInteractOutsidepreventDefault +sm:sizing); the sharedSheetis untouched.assistant.panel.tscloses with Escape, which still works.Closes #762