Music tracks will be played continuously while game speed is set to paused

[Max5377]

MusicPlayer will now continue to play tracks while game is paused, instead of playing one track and get silenced until unpaused.
Edit: rebase.
Edit2: rebase.

[bszlrd]

Maybe fade out the music upon pause, and fade in when unpaused?

[Max5377]

@nozmajner I meant that this happenes when you set your game speed to pause, I can change description to clarify more. But I suppose this can be added, maybe in the other PR?
Edit: Sorry, already stated that. But I think this feature can be added in the pause menu.

[bszlrd]

Oh sorry, I thought it is a report, not a PR

[impaktor]

It's not obvious to me that game music should keep playing in paused mode. (What if you paused because your boss is walking towards your computer, when you're sneakily playing pioneer waiting for your work code to compile?)

[Max5377]

@impaktor
Well... https://youtu.be/CEvzFcqKbXw?feature=shared&t=13

Some thoughts about it:

1. Make music continue to play, but at the volume of 0 or just get really quiet (10-25% of current volume);
2. Music stops to play completely, with sound indication (like clock sound in Sims 3 or maybe some wind sound).

[impaktor]

Lest we forget this PR; @WKFO do you have any objections to this?

[fluffyfreak]

This seems like a very simple fix good job 👍

[fluffyfreak]

This PR does what I'd expect but it appears that it has been heavily discussed in relation to #6165 and now everything has been forgotten about.

I would expect music to keep playing when the game is paused, wider refactorings of the audio subsystem aside.

@impaktor @WKFO any objections to merging this?