Skip to content

fix(types): narrow ReqId to string|number#393

Open
mcollina wants to merge 1 commit intomasterfrom
fix/issue-268-reqid-type
Open

fix(types): narrow ReqId to string|number#393
mcollina wants to merge 1 commit intomasterfrom
fix/issue-268-reqid-type

Conversation

@mcollina
Copy link
Copy Markdown
Member

@mcollina mcollina commented Feb 9, 2026

Summary

  • narrow ReqId type from number | string | object to number | string
  • update type tests to remove object/Buffer req id acceptance
  • add tsd negative assignability assertions for invalid GenReqId return types
  • update README genReqId docs to specify (req, res) and string | number return

Fixes #268

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The reqId type is overly-broad

1 participant