Skip to content

executor: reduce TestDistSQLSharedKVRequestRace iterations to fix CI timeout #67675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joechenrh wants to merge 3 commits into
base: master
Choose a base branch
from
+4 −1
Open

executor: reduce TestDistSQLSharedKVRequestRace iterations to fix CI timeout #67675

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e70180b
executor: reduce TestDistSQLSharedKVRequestRace iterations to fix CI …
joechenrh Apr 10, 2026
379949c
executor: add comment explaining iteration count rationale
joechenrh Apr 10, 2026
39c3ec6
executor: use for range idiom
joechenrh Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion pkg/executor/test/distsqltest/distsql_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,10 @@ func TestDistSQLSharedKVRequestRace(t *testing.T) {
}
for _, mode := range replicaReadModes {
tk.MustExec(fmt.Sprintf("set session tidb_replica_read = '%s'", mode))
for i := 0; i < 20; i++ {
// Few iterations suffice: Go's race detector is deterministic (catches on first
// occurrence), and RequestBuilder.used guards reuse at build time. Keep this low
// to stay well under the Bazel "moderate" timeout with -race enabled.
for range 5 {
// index lookup
tk.MustQuery("select * from t force index(ic) order by c asc limit 500").Check(testkit.Rows(expects...))
// index merge
Expand Down
Loading