pkg/dxf: avoid misleading error log on context cancel (#67612)#67673
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughModified error logging in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.11.4)Command failed Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Benjamin2037, D3Hunter The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
/retest |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-nextgen-202603 #67673 +/- ##
===========================================================
Coverage ? 77.5451%
===========================================================
Files ? 1960
Lines ? 543433
Branches ? 0
===========================================================
Hits ? 421406
Misses ? 121175
Partials ? 852
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
744884d
into
pingcap:release-nextgen-202603
This is an automated cherry-pick of #67612
What problem does this PR solve?
Issue Number: ref #67631
Problem Summary:
When a distributed task subtask exits because the context is canceled, the executor currently logs it as a failure. This produces misleading error logs for expected cancellation paths.
What changed and how does it work?
In
BaseTaskExecutor.Run, handlerunSubtaskerrors by type:llog.IsContextCanceledError(err)), log an info message.This preserves error visibility for real failures while reducing noisy/misleading logs for expected cancellations.
Check List
Tests
Side effects
Documentation
Release note
Summary by CodeRabbit