Release 8.5 20260225 v8.5.2 | pd=@pull-10500-9f9829d_linux_amd64 by ClamChowderTiDB · Pull Request #67474 · pingcap/tidb

ClamChowderTiDB · 2026-03-31T17:21:37Z

Release 8.5 20260225 v8.5.2

What problem does this PR solve?

Release 8.5 20260225 v8.5.2

Issue Number: close #xxx

Problem Summary:

What changed and how does it work?

Check List

Release 8.5 20260225 v8.5.2

Release note

Release 8.5 20260225 v8.5.2

Summary by CodeRabbit

New Features
- ALTER DATABASE/SCHEMA ... READ ONLY with info-schema visibility, new error codes, and enforcement of write-blocking (with a privileged bypass).
- BR: new hidden operator commands — force-flush and checksum-as.
- BR: memory monitor and status endpoint exposing /metrics.
Improvements
- Expanded BR/RawKV/restore Prometheus metrics and registration.
- Lightning: customizable ON DUPLICATE resolution and per-engine region sizing.
- Restore: support for applying TiKV config override files.

X-Original-Commit: 2acac1f

X-Original-Commit: 2bee827

X-Original-Commit: da77778

X-Original-Commit: e7cd229

X-Original-Commit: 3e68831

…cap#58228) X-Original-Commit: c307305

X-Original-Commit: ac41aa0

pingcap#58029) X-Original-Commit: aa73cf9

X-Original-Commit: 1b86dc0

…58801) X-Original-Commit: 7b6e626

X-Original-Commit: 6ef54f9

X-Original-Commit: 95e9ea2

X-Original-Commit: ee93416

X-Original-Commit: c1f0d95

X-Original-Commit: 03d4d87

X-Original-Commit: 4ce4795

X-Original-Commit: 20fcc24

X-Original-Commit: 521ddcf

X-Original-Commit: 49f7b74

…1347) (pingcap#62115) X-Original-Commit: b9e2ec9

X-Original-Commit: 3dfe410

X-Original-Commit: 9637624

X-Original-Commit: 7972b48

X-Original-Commit: d6cedfb65c5009175a4a76b8e6bb09a946c8e827

X-Original-Commit: a108cf3dd784589eeb040c242abe1b7bb1b25df4

X-Original-Commit: a35eab239a35d2dda83598614c6e72c253dc4bc6

…emove some unused code. X-Original-Commit: 5dc66519fc39a75e098dd5d13f6542ddc311532a

…61090) X-Original-Commit: b6a6e7336ba663549af921e420784b99950289d5

X-Original-Commit: 38b45fb3150a3ddf50eab6b9afab2e032059618d

X-Original-Commit: dd557092ba7086d90997c9c0b5c07eaf7491ad57

tiprow · 2026-04-02T22:26:39Z

@ClamChowderTiDB: No presubmit jobs available for pingcap/tidb@release-8.5-20260225-v8.5.2

Details

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

maybeGetDownloadableArtifact never parsed the urls= kwarg, leaving existingMirrors always empty. This caused isMirror to regenerate every entry with 4 PingCap + proxy URLs, while the committed DEPS.bzl had either 4 PingCap-only or proxy-only entries, causing check-bazel-prepare to always fail. With urls properly parsed, existingMirrors is populated and reuseOldMirror correctly fires for all existing entries, preserving their URLs verbatim. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Adding proxy as a 5th URL in the isMirror branch caused check-bazel-prepare to fail: the isMirror branch runs for all entries when existingMirrors is empty (skylarkutil was not parsing urls), generating 4 PingCap + proxy while committed DEPS.bzl has only 4 PingCap — causing a diff for every entry. The skylarkutil urls-parsing fix makes reuseOldMirror work for existing entries (both standard 4-PingCap and fork proxy-only), so isMirror only fires for genuinely new modules. For those, 4 PingCap URLs is the correct output (same as original upstream behavior). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

gazelle runs before the mirror in make bazel_ci_prepare and rewrites DEPS.bzl, stripping all urls= entries (converting to sum/version format). The mirror then reads the on-disk file and sees no URLs, so existingMirrors is empty and reuseOldMirror never fires. For cherry-picked modules whose PingCap mirror URLs return 404 (kvproto, client-go, pd/client), the generated DEPS.bzl ends up with no proxy fallback, causing tazel to fail. Fix: read DEPS.bzl from git HEAD before gazelle touched it. This gives reuseOldMirror the correct URL lists (including proxy URLs added by fix_go_mod.py), so the mirror preserves those entries verbatim. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

ClamChowderTiDB · 2026-04-02T23:49:20Z

/test pull-br-integration-test

tiprow · 2026-04-02T23:49:36Z

@ClamChowderTiDB: No presubmit jobs available for pingcap/tidb@release-8.5-20260225-v8.5.2

Details

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

PingCap's pd-server v8.5.x does not implement the /pd/api/v1/admin/cluster/markers/pitr-restore-mode HTTP endpoint. SetPitrRestoreMark returned 404, causing every RESTORE DATABASE SQL statement to fail unconditionally in the brietest suite. Treat a 404 response as "endpoint not supported by this PD version", log a warning, and proceed without setting the mark. The mark is only meaningful for PD servers that actually implement it, so skipping it on older deployments is safe. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Simplify if/else to satisfy the all_revive nogo linter. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

ti-chi-bot · 2026-04-03T00:17:41Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign 3pointer, d3hunter, lance6716, winoros, yudongusa, zanmato1984 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ClamChowderTiDB · 2026-04-03T01:19:19Z

/test pull-check
/test mysql-test

tiprow · 2026-04-03T01:19:34Z

@ClamChowderTiDB: No presubmit jobs available for pingcap/tidb@release-8.5-20260225-v8.5.2

Details

In response to this:

/test pull-check
/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ClamChowderTiDB · 2026-04-03T01:20:07Z

/test check-dev

tiprow · 2026-04-03T01:20:22Z

@ClamChowderTiDB: No presubmit jobs available for pingcap/tidb@release-8.5-20260225-v8.5.2

Details

In response to this:

/test check-dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ClamChowderTiDB · 2026-04-03T04:15:36Z

/test build

tiprow · 2026-04-03T04:15:53Z

@ClamChowderTiDB: No presubmit jobs available for pingcap/tidb@release-8.5-20260225-v8.5.2

Details

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ClamChowderTiDB · 2026-04-16T17:57:52Z

/retest

nolouch · 2026-04-30T21:46:53Z

/test pull_check

ti-chi-bot · 2026-04-30T21:46:57Z

@nolouch: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build

/test check-dev

/test check-dev2

/test mysql-test

/test pull-br-integration-test

/test pull-unit-test-ddlv1

/test unit-test

The following commands are available to trigger optional jobs:

/test pull-common-test

/test pull-e2e-test

/test pull-integration-common-test

/test pull-integration-copr-test

/test pull-integration-ddl-test

/test pull-integration-e2e-test

/test pull-integration-jdbc-test

/test pull-integration-mysql-test

/test pull-integration-nodejs-test

/test pull-integration-python-orm-test

/test pull-integration-tidb-tools-test

/test pull-lightning-integration-test

/test pull-mysql-client-test

/test pull-sqllogic-test

Use /test all to run the following jobs that were automatically triggered:

pingcap/tidb/release-8.5/pull_br_integration_test

pingcap/tidb/release-8.5/pull_build

pingcap/tidb/release-8.5/pull_check

pingcap/tidb/release-8.5/pull_check2

pingcap/tidb/release-8.5/pull_mysql_test

pingcap/tidb/release-8.5/pull_unit_test

pingcap/tidb/release-8.5/pull_unit_test_ddlv1

Details

In response to this:

/test pull_check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow · 2026-04-30T21:47:00Z

@nolouch: No presubmit jobs available for pingcap/tidb@release-8.5-20260225-v8.5.2

Details

In response to this:

/test pull_check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

nolouch · 2026-04-30T21:47:41Z

/test all

tiprow · 2026-04-30T21:47:47Z

@nolouch: No presubmit jobs available for pingcap/tidb@release-8.5-20260225-v8.5.2

Details

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

nolouch · 2026-05-01T00:30:37Z

/test all

tiprow · 2026-05-01T00:30:43Z

@nolouch: No presubmit jobs available for pingcap/tidb@release-8.5-20260225-v8.5.2

Details

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ti-chi-bot · 2026-05-06T21:59:08Z

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/invalid-title label, please follow title format, for example pkg [, pkg2, pkg3]: what is changed or *: what is changed.

_{📖 For more info, you can check the "Contribute Code" section in the development guide.}

3pointer · 2026-05-06T21:59:15Z

/test all

tiprow · 2026-05-06T21:59:44Z

@3pointer: No presubmit jobs available for pingcap/tidb@release-8.5-20260225-v8.5.2

Details

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ti-chi-bot · 2026-05-06T22:10:38Z

@ClamChowderTiDB: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
idc-jenkins-ci-tidb/check_dev_2	`09fdc29`	link	true	`/test check-dev2`
pull-br-integration-test	`09fdc29`	link	true	`/test pull-br-integration-test`
pull-unit-test-ddlv1	`09fdc29`	link	true	`/test pull-unit-test-ddlv1`
idc-jenkins-ci-tidb/unit-test	`09fdc29`	link	true	`/test unit-test`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

ClamChowderTiDB and others added 30 commits March 27, 2026 17:56

delete .dockerignore

ed8e14b

X-Original-Commit: 2acac1f

[submodule] include tikv-client-go submodule

17e5f4d

X-Original-Commit: 2bee827

disable flaky tests

3454b4c

X-Original-Commit: da77778

cherry pick minRegionNum to 7.5

52a6b24

X-Original-Commit: e7cd229

remove 'pkg/extension/enterprise' submodule

6da2dbe

X-Original-Commit: 3e68831

util: Change the output dir of the PLAN REPLAYER to be temp_dir (ping…

7f5f157

…cap#58228) X-Original-Commit: c307305

[lightning] customize on dup logic

838f0b4

X-Original-Commit: ac41aa0

planner: fix index range intersection for in-list and other predicates (

e8168d2

pingcap#58029) X-Original-Commit: aa73cf9

fix bazel breakages picked in

66af031

X-Original-Commit: 1b86dc0

Cherry-pick: br/cmd: added operator checksum-as|force-flush (pingcap#…

5c2978e

…58801) X-Original-Commit: 7b6e626

[br] add unit tests to CI

34af037

X-Original-Commit: 6ef54f9

br: set default restore checksum to false (pingcap#60328)

4ef6d81

X-Original-Commit: 95e9ea2

br: mem dump when about to OOM (pingcap#59234)

b05b568

X-Original-Commit: ee93416

br: metrics server and initial restore metrics (pingcap#60942)

91f4a06

X-Original-Commit: c1f0d95

update tikv go client to 8.5.2 branch

5462297

X-Original-Commit: 03d4d87

parser: update pingcap/errors to fix failed test cases (pingcap#61840)

c877c3b

X-Original-Commit: 4ce4795

disable flaky tests

676a2f0

X-Original-Commit: 20fcc24

additional goleak exceptions to address CI failures

769ca63

X-Original-Commit: 521ddcf

meta/autoid: reduce get autoID's backoff

b386a91

X-Original-Commit: 49f7b74

log restore: filter backupmeta file by ts to speed up pitr (pingcap#6…

79d75da

…1347) (pingcap#62115) X-Original-Commit: b9e2ec9

[submodule] update client-go to bring prefer-leader fix

6a0796a

X-Original-Commit: 3dfe410

consume tikv/client-go as a go module

ac291c6

X-Original-Commit: 9637624

Enable/disable PD restore mode during PiTR restore

8eef555

X-Original-Commit: 7972b48

fix defer value leak, pd client version

4c4c6fa

X-Original-Commit: d6cedfb65c5009175a4a76b8e6bb09a946c8e827

update client-go and instruction

b2d2816

X-Original-Commit: a108cf3dd784589eeb040c242abe1b7bb1b25df4

Support dynamic config overrides for TIKV during Restoring process.

41770e1

X-Original-Commit: a35eab239a35d2dda83598614c6e72c253dc4bc6

Support dynamic config overrides for TIKV during Restoring process. R…

a8665d7

…emove some unused code. X-Original-Commit: 5dc66519fc39a75e098dd5d13f6542ddc311532a

placement: fix alter meta range cannot work (pingcap#60889) (pingcap#…

f7e0529

…61090) X-Original-Commit: b6a6e7336ba663549af921e420784b99950289d5

fix unit test on arm v8.5

aba32ce

X-Original-Commit: 38b45fb3150a3ddf50eab6b9afab2e032059618d

lightning Exit code=1 if terminate when job not finished

a7799ac

X-Original-Commit: dd557092ba7086d90997c9c0b5c07eaf7491ad57

ClamChowderTiDB and others added 3 commits April 2, 2026 18:29

ClamChowderTiDB and others added 2 commits April 2, 2026 20:00

br: fix early-return lint in SetPitrRestoreMark fallback

09fdc29

Simplify if/else to satisfy the all_revive nogo linter. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

nolouch changed the title ~~Release 8.5 20260225 v8.5.2~~ Release 8.5 20260225 v8.5.2 | pd=release-8.5-20260225-v8.5.2 Apr 30, 2026

nolouch changed the title ~~Release 8.5 20260225 v8.5.2 | pd=release-8.5-20260225-v8.5.2~~ Release 8.5 20260225 v8.5.2 | pd=v8.5.2-10388 May 1, 2026

3pointer changed the title ~~Release 8.5 20260225 v8.5.2 | pd=v8.5.2-10388~~ Release 8.5 20260225 v8.5.2 | pd=@pull-10500-9f9829d_linux_amd64 May 6, 2026

Conversation

ClamChowderTiDB commented Mar 31, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

Summary by CodeRabbit

Uh oh!

tiprow Bot commented Apr 2, 2026

Uh oh!

ClamChowderTiDB commented Apr 2, 2026

Uh oh!

tiprow Bot commented Apr 2, 2026

Uh oh!

ti-chi-bot Bot commented Apr 3, 2026

Uh oh!

ClamChowderTiDB commented Apr 3, 2026

Uh oh!

tiprow Bot commented Apr 3, 2026

Uh oh!

ClamChowderTiDB commented Apr 3, 2026

Uh oh!

tiprow Bot commented Apr 3, 2026

Uh oh!

ClamChowderTiDB commented Apr 3, 2026

Uh oh!

tiprow Bot commented Apr 3, 2026

Uh oh!

ClamChowderTiDB commented Apr 16, 2026

Uh oh!

nolouch commented Apr 30, 2026

Uh oh!

ti-chi-bot Bot commented Apr 30, 2026

Uh oh!

tiprow Bot commented Apr 30, 2026

Uh oh!

nolouch commented Apr 30, 2026

Uh oh!

tiprow Bot commented Apr 30, 2026

Uh oh!

nolouch commented May 1, 2026

Uh oh!

tiprow Bot commented May 1, 2026

Uh oh!

ti-chi-bot Bot commented May 6, 2026

Uh oh!

3pointer commented May 6, 2026

Uh oh!

tiprow Bot commented May 6, 2026

Uh oh!

ti-chi-bot Bot commented May 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

ClamChowderTiDB commented Mar 31, 2026 •

edited by coderabbitai Bot

Loading

ti-chi-bot Bot commented May 6, 2026 •

edited

Loading