Skip to content

br: added crr package and checkpoint advancer#66913

Merged
ti-chi-bot[bot] merged 55 commits intopingcap:masterfrom
YuJuncen:codex/sync-checkpoint-advancer
Apr 7, 2026
Merged

br: added crr package and checkpoint advancer#66913
ti-chi-bot[bot] merged 55 commits intopingcap:masterfrom
YuJuncen:codex/sync-checkpoint-advancer

Conversation

@YuJuncen
Copy link
Copy Markdown
Contributor

@YuJuncen YuJuncen commented Mar 11, 2026

What problem does this PR solve?

Issue Number: close #67416

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

YuJuncen and others added 30 commits March 3, 2026 16:32
Signed-off-by: yujuncen <yujuncen@pingcap.cn>
Signed-off-by: hillium <yu745514916@live.com>
Signed-off-by: hillium <yu745514916@live.com>
Signed-off-by: hillium <yu745514916@live.com>
Signed-off-by: hillium <yu745514916@live.com>
Signed-off-by: hillium <yu745514916@live.com>
Signed-off-by: hillium <yu745514916@live.com>
Signed-off-by: hillium <yu745514916@live.com>
Signed-off-by: hillium <yu745514916@live.com>
Signed-off-by: hillium <yu745514916@live.com>
Signed-off-by: hillium <yu745514916@live.com>
Signed-off-by: hillium <yu745514916@live.com>
Signed-off-by: hillium <yu745514916@live.com>
Signed-off-by: hillium <yu745514916@live.com>
Signed-off-by: hillium <yu745514916@live.com>
Signed-off-by: hillium <yu745514916@live.com>
Signed-off-by: hillium <yu745514916@live.com>
Signed-off-by: hillium <yu745514916@live.com>
Signed-off-by: hillium <yu745514916@live.com>
Signed-off-by: hillium <yu745514916@live.com>
Signed-off-by: hillium <yu745514916@live.com>
Signed-off-by: hillium <yu745514916@live.com>
Signed-off-by: hillium <yu745514916@live.com>
Signed-off-by: hillium <yu745514916@live.com>
Signed-off-by: hillium <yu745514916@live.com>
Signed-off-by: hillium <yu745514916@live.com>
Signed-off-by: hillium <yu745514916@live.com>
Signed-off-by: hillium <yu745514916@live.com>
Leavrth and others added 4 commits March 25, 2026 11:27
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
…vancer

add metrics for sync checkpoint advancer
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
@ti-chi-bot ti-chi-bot Bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 30, 2026
@Leavrth Leavrth marked this pull request as ready for review March 30, 2026 09:41
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 30, 2026
@pantheon-ai
Copy link
Copy Markdown

pantheon-ai Bot commented Mar 30, 2026

Review failed due to infrastructure/execution failure after retries. Please re-trigger review.

ℹ️ Learn more details on Pantheon AI.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 30, 2026

Codecov Report

❌ Patch coverage is 70.30935% with 883 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.6756%. Comparing base (864cba9) to head (ca80c30).
⚠️ Report is 161 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #66913        +/-   ##
================================================
+ Coverage   77.6911%   78.6756%   +0.9844%     
================================================
  Files          2012       1982        -30     
  Lines        550857     567693     +16836     
================================================
+ Hits         427967     446636     +18669     
+ Misses       121174     119960      -1214     
+ Partials       1716       1097       -619     
Flag Coverage Δ
integration 44.2756% <6.2401%> (-3.8803%) ⬇️
unit 76.6563% <69.8049%> (+0.3950%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 61.5065% <ø> (+4.7091%) ⬆️
parser ∅ <ø> (∅)
br 64.6325% <71.0872%> (+3.7092%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 7, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 7, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-03-30 06:00:01.40596355 +0000 UTC m=+158406.611323627: ☑️ agreed by Leavrth.
  • 2026-04-07 03:13:59.202255633 +0000 UTC m=+839644.407615689: ☑️ agreed by RidRisR.

Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
@hawkingrei
Copy link
Copy Markdown
Member

/retest

Copy link
Copy Markdown
Contributor

@D3Hunter D3Hunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

obj store part lgtm

}
status := head.ReplicationStatus
switch status {
case "COMPLETE", "COMPLETED", "REPLICA":
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe make them enum

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These contants should be provided by the AWS s3 SDK IMO.

@D3Hunter
Copy link
Copy Markdown
Contributor

D3Hunter commented Apr 7, 2026

/approve

Leavrth added 2 commits April 7, 2026 15:49
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 7, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, Leavrth, RidRisR

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Leavrth
Copy link
Copy Markdown
Contributor

Leavrth commented Apr 7, 2026

/retest

@tiprow
Copy link
Copy Markdown

tiprow Bot commented Apr 7, 2026

@YuJuncen: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
tidb_parser_test ca80c30 link true /test tidb_parser_test
fast_test_tiprow ca80c30 link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot Bot merged commit 90dda82 into pingcap:master Apr 7, 2026
37 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Downstream Checkpoint Advancer for AWS s3 CRR

5 participants