Skip to content

build(deps): sql-formatter-plus-plus -> sql-formatter-plus#697

Closed
TennyZhuang wants to merge 1 commit intopingcap:masterfrom
TennyZhuang:sql-formatter
Closed

build(deps): sql-formatter-plus-plus -> sql-formatter-plus#697
TennyZhuang wants to merge 1 commit intopingcap:masterfrom
TennyZhuang:sql-formatter

Conversation

@TennyZhuang
Copy link
Copy Markdown
Contributor

Revert parts of #489

Latest Firefox stable release has supported Unicode property escapes

Signed-off-by: TennyZhuang zty0826@gmail.com

Signed-off-by: TennyZhuang <zty0826@gmail.com>
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jul 19, 2020

CLA assistant check
All committers have signed the CLA.

@kennytm
Copy link
Copy Markdown
Contributor

kennytm commented Jul 19, 2020

I agree with the discussion in the Slack channel that

it's too new. Maybe we can remove it after several months

We should at least wait until Firefox 68 ESR went end-of-life on September 22nd.

@breezewish breezewish added the status/DNM Do not merge label Jul 20, 2020
@breezewish
Copy link
Copy Markdown
Member

Thanks for the contribution! I would like to hold this PR until our supported browsers all have this feature.

@stale
Copy link
Copy Markdown

stale Bot commented Sep 18, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@ti-chi-bot
Copy link
Copy Markdown
Member

@TennyZhuang: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@breezewish
Copy link
Copy Markdown
Member

Considering that this may further break our compatibility promise, I think this PR may not be accepted in recent time.

@breezewish breezewish closed this Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants