v8.5.6: refresh TopSQL docs and screenshots (#22559)#22734
Conversation
ti-chi-bot
added
lgtm
needs-1-more-lgtm
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Top SQL documentation to include the new multi-dimensional TiKV Network IO collection feature introduced in v8.5.6 and v9.0.0. This enhancement allows for monitoring network and logical I/O metrics with additional aggregation dimensions like Table, DB, and Region. Corresponding updates were made to TiDB Cloud Clinic and TiKV configuration documentation. Review feedback primarily suggested refinements to sentence structure, clarity, and terminology consistency to better align with the style guide.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
qiancai
changed the title
|
@yibin87: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiancai The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
Bot
merged commit dfc3c03
into
pingcap:feature/preview-v8.5.6
3 participants
This is an automated cherry-pick of #22559
What is changed, added or deleted? (Required)
dashboard/top-sql.mdto match the currentpingcap/tidb-dashboardbehavior for TopSQL.5/20/100,Order By CPU/Order By Network/Order By Logical IO, TiKVBy Query/By Table/By DB/By Region, and the enable/disable behavior for TiKV network IO collection.Order Bydropdown and the TopSQL settings drawer for enabling TiKV Network IO collection.Monitor TopSQLsection intidb-cloud/tidb-cloud-clinic.mdso it describes multi-dimensional hotspot analysis instead of CPU-only analysis.Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?