Skip to content

tidb: add the join order related variable tidb_opt_join_reorder_through_sel#21292

Merged
ti-chi-bot[bot] merged 7 commits intopingcap:masterfrom
Reminiscent:join_order_through_sel
Apr 9, 2026
Merged

tidb: add the join order related variable tidb_opt_join_reorder_through_sel#21292
ti-chi-bot[bot] merged 7 commits intopingcap:masterfrom
Reminiscent:join_order_through_sel

Conversation

@Reminiscent
Copy link
Copy Markdown
Contributor

@Reminiscent Reminiscent commented Jan 22, 2026 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Related to the pingcap/tidb#64535 and pingcap/tidb#65742

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 22, 2026
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jan 23, 2026

@Reminiscent: once the present PR merges, I will cherry-pick it on top of release-8.5 in the new PR and assign it to you.

Details

In response to this:

/cherrypick release-8.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@hfxsd hfxsd added translation/doing This PR’s assignee is translating this PR. affects-9.0 This bug affects the 9.0.x versions. v9.0-beta.3 This PR/issue applies to TiDB v9.0-beta.3. and removed missing-translation-status This PR does not have translation status info. affects-9.0 This bug affects the 9.0.x versions. labels Feb 24, 2026
@hfxsd hfxsd self-assigned this Feb 24, 2026
@hfxsd hfxsd added the type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. label Feb 24, 2026
hfxsd
hfxsd reviewed Feb 24, 2026
View reviewed changes
hfxsd
hfxsd reviewed Feb 24, 2026
View reviewed changes
@hfxsd hfxsd added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Feb 24, 2026
@hfxsd hfxsd mentioned this pull request Feb 24, 2026
Merged
14 tasks
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Feb 24, 2026

@guo-shaoge: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hfxsd hfxsd requested a review from lilin90 February 24, 2026 06:59
@hfxsd hfxsd added the requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. label Mar 20, 2026
hfxsd
hfxsd reviewed Mar 20, 2026
View reviewed changes
@hfxsd hfxsd requested a review from Oreoxmt April 8, 2026 07:50
Oreoxmt
Oreoxmt reviewed Apr 8, 2026
View reviewed changes
Oreoxmt
Oreoxmt reviewed Apr 8, 2026
View reviewed changes
Oreoxmt
Oreoxmt reviewed Apr 8, 2026
View reviewed changes
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 8, 2026
@hfxsd @Oreoxmt
Apply suggestions from code review
2b6bf7f 
Co-authored-by: Aolin <aolinz@outlook.com>
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 9, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Apr 9, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-04-08 08:09:47.165697773 +0000 UTC m=+943792.371057830: ☑️ agreed by Oreoxmt.
  • 2026-04-09 02:42:46.204249931 +0000 UTC m=+1010571.409609998: ☑️ agreed by hfxsd.

@hfxsd
Copy link
Copy Markdown
Collaborator

hfxsd commented Apr 9, 2026

/approve

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Apr 9, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Apr 9, 2026
@ti-chi-bot ti-chi-bot bot merged commit b2104f4 into pingcap:master Apr 9, 2026
11 checks passed
@hfxsd hfxsd added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Apr 9, 2026
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Apr 9, 2026

In response to a cherrypick label: new pull request created to branch release-8.5: #21522.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 9, 2026
Merged
14 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Apr 9, 2026
@ti-chi-bot
tidb: add the join order related variable `tidb_opt_join_reorder_thro…
dc01dc5 
…ugh_sel` (#21292) (#21522)
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 10, 2026
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guo-shaoge guo-shaoge guo-shaoge approved these changes

@hfxsd hfxsd hfxsd approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@lilin90 lilin90 Awaiting requested review from lilin90

Assignees

@hfxsd hfxsd

Labels

approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v9.0-beta.3 This PR/issue applies to TiDB v9.0-beta.3.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Reminiscent @ti-chi-bot @hfxsd @guo-shaoge @Oreoxmt