Fix: import aiostream only if sys.version < python 3.9#1023
Open
lduchosal wants to merge 2 commits into
Open
Conversation
Member
|
If you don't import the module, then the code will fail to run since this module is used in quite a few places.
Why would you skip it for python < 3.9? What issue are you trying to solve here?
|
Author
|
issue #1022 sum up my problem. aiostream is not needed in python 39 .. Everything works fine if imports are removed. |
Member
|
I don't know why you assume that it's not necessary, but it is. There's a lot of code relying on it (just look for other references to Most of the usages of this library is in tests, but not all of them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.