Skip to content

fix: normalize trailing slashes in middleware mount paths (#2281) #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hanu-14 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: normalize trailing slashes in middleware mount paths (#2281) #203

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,6 +395,14 @@ Router.prototype.use = function use (handler) {
// add the middleware
debug('use %o %s', path, fn.name || '<anonymous>')

// Normalize mount path: strip trailing slash for consistent behavior
// with strict sub-routers. req.baseUrl already strips trailing slashes,
// so this keeps mount paths consistent with baseUrl semantics.
// See expressjs/express#2281.
if (typeof path === 'string' && path.length > 1 && path.endsWith('/')) {
path = path.slice(0, -1)
}

const layer = new Layer(path, {
sensitive: this.caseSensitive,
strict: false,
Expand Down