Skip to content

Fix multi-byte UTF-8 corruption in streaming Ask responses #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
surgaev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix multi-byte UTF-8 corruption in streaming Ask responses #228

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions src/features/ask/askService.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,6 +370,7 @@ class AskService {
async _processStream(reader, askWin, sessionId, signal) {
const decoder = new TextDecoder();
let fullResponse = '';
let lineBuffer = '';

try {
this.state.isLoading = false;
Expand All @@ -379,14 +380,23 @@ class AskService {
const { done, value } = await reader.read();
if (done) break;

const chunk = decoder.decode(value);
const lines = chunk.split('\n').filter(line => line.trim() !== '');
// { stream: true } tells TextDecoder to hold back any incomplete
// multi-byte UTF-8 sequence at the chunk boundary instead of mangling it
// (critical for Cyrillic/other multi-byte text split across network chunks).
lineBuffer += decoder.decode(value, { stream: true });

// SSE lines can also be split across chunk boundaries — only process
// complete lines (ending in \n) and carry any trailing partial line over
// to be prefixed onto the next chunk.
const lines = lineBuffer.split('\n');
lineBuffer = lines.pop() || '';

for (const line of lines) {
if (line.trim() === '') continue;
if (line.startsWith('data: ')) {
const data = line.substring(6);
if (data === '[DONE]') {
return;
return;
}
try {
const json = JSON.parse(data);
Expand Down