lexbor: Refresh patch files#22517
Merged
Merged
Conversation
TimWolla
requested review from
iluuu1994 and
ndossche
and removed request for
iluuu1994 and
kocsismate
iluuu1994
approved these changes
Jun 29, 2026
iluuu1994
left a comment
iluuu1994
left a comment
Member
There was a problem hiding this comment.
Thank you! This should probably be backported to 8.4. The script lives in the old directory though, so this can be done later.
The filename of the patch file is derived from the commit message. When the commit message changes or the patch was initially added with the wrong name the patch file might be renamed and exist twice when it's not deleted.
This includes the git version number by default which makes the patches unstable.
Including the commit ID of the temporary commit in the patch files makes them unstable.
TimWolla
requested review from
Girgias,
LamentXU123,
SakiTakamachi,
adoy,
arnaud-lb,
derickr,
devnexen and
dstogov
as code owners
TimWolla
force-pushed
the
lexbor-update-patch-handling
branch
from
8e1313f to
e78117c
Compare
TimWolla
removed request for
Girgias,
LamentXU123,
SakiTakamachi,
adoy,
arnaud-lb,
derickr,
devnexen and
dstogov
TimWolla
added a commit
that referenced
this pull request
Jun 29, 2026
* PHP-8.4: lexbor: Refresh patch files (#22517)
TimWolla
added a commit
that referenced
this pull request
Jun 29, 2026
* PHP-8.5: lexbor: Run `update_lexbor.sh` (PHP 8.5) lexbor: Refresh patch files (#22517)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.