Skip to content
This repository was archived by the owner on Nov 6, 2019. It is now read-only.
This repository was archived by the owner on Nov 6, 2019. It is now read-only.

Stretch factors and size basis should be initialized when sizer is created. #442

Description

@sccolbert

For BoxLayout and SplitLayout, these properties should be initialized when the sizer is created (if possible). In some cases, the widget will be resized before the fit request is processed. This means the initial layout will have stale data. In the case of the SplitLayout, this causes the initial layout to be completely wrong when one widget has a stretch factor of zero.

https://github.com/phosphorjs/phosphor/blob/master/packages/widgets/src/splitlayout.ts#L297

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions