Repository navigation
fix: allow apps to bundle sh - #266
Merged
Merged
Conversation
Let explicitly declared app requirements and NOTICE entries include sh now that the automation environment no longer provides it. Written by Codex.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow explicitly declared applications to package
shand include its license in generatedNOTICEfiles after the dependency is removed from Phantom's shared automation environments.This is the packaging prerequisite for the Slack change and the application slice of PSAAS-36343 / CVE-2026-54552 context.
Changes
shfrom the dependency packager's platform-provided wheel exclusions.shfrom the NOTICE generator's platform-provided package exclusions.Validation
pytest local_hooks/tests/test_package_app_dependencies.py local_hooks/tests/test_generate_notice.py: 28 passed.sh-1.14.3.shMIT attribution.Review focus
Please verify that an app's explicit
shrequirement is retained in generated metadata and that the corresponding license block is included inNOTICE, while platform-provided dependency handling remains unchanged for the other excluded packages.Written by Codex.