Skip to content

fix: declare uv for notice generation - #249

Merged
phantom-jacob merged 1 commit into
mainfrom
sodle/notice-hook-declare-uv
Jul 20, 2026
Merged

phantom-jacob merged 1 commit into
mainfrom
sodle/notice-hook-declare-uv

Conversation

@sodle-splunk

Copy link
Copy Markdown
Collaborator

Summary

  • declare uv as a normal runtime dependency of local-hooks
  • keep notice generation on the isolated uv tool path in hosted pre-commit environments
  • add a regression assertion for packaged dependency metadata

Why

The notice hook prefers uv but did not install it in its isolated pre-commit environment. Hosted connector CI therefore fell back to pip-installing every connector runtime dependency. Traditional connectors with platform-specific packages such as pykerberos then fail before notice generation, even though their generated notice and connector code are valid.

This blocks:

Parent campaign epic: ESPM-5228.

Validation

  • UV_CACHE_DIR=/tmp/uv-cache uv run --with pytest pytest local_hooks/tests/test_generate_notice.py -q (17 passed)
  • UV_NO_CONFIG=1 PIP_INDEX_URL=https://pypi.org/simple pre-commit run --all-files

This pull request was prepared by Codex.

@phantom-jacob
phantom-jacob merged commit cd3ffc6 into main Jul 20, 2026
4 checks passed
@phantom-jacob
phantom-jacob deleted the sodle/notice-hook-declare-uv branch July 20, 2026 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants