Skip to content

fix: sdkify pre commit - #200

Merged
tapishj-splunk merged 5 commits into
mainfrom
tapishj/fix-sdkify-pre-commit
Sep 30, 2025
Merged

tapishj-splunk merged 5 commits into
mainfrom
tapishj/fix-sdkify-pre-commit

Conversation

@tapishj-splunk

@tapishj-splunk tapishj-splunk commented Sep 19, 2025 •

Copy link
Copy Markdown
Contributor
  • I wouldn't say this is a fully sdkfied pre-commit yet, more like a bare bones version. For example, the get_opt_params static test was super specific to the old app types and not very effective for sdk apps.
  • Further, right now pre-commit is simply going to using soarapps manifest create to create the app json, which different hooks in this repo will use. This is fine, but we should probably add a verify pyproject.toml hook, since that is the new truth of source not the json file. Although, the sdk build likely handles a lot of the error checking for the toml file already

for the http app:
Screenshot 2025-09-19 at 5 08 45 PM

on github: https://github.com/splunk-soar-connectors/http/actions/runs/17924086980/job/50967122950

@tapishj-splunk
tapishj-splunk force-pushed the tapishj/fix-sdkify-pre-commit branch 15 times, most recently from 6ac4a02 to d2abcc3 Compare September 19, 2025 23:08
@tapishj-splunk
tapishj-splunk force-pushed the tapishj/fix-sdkify-pre-commit branch 4 times, most recently from e3fa264 to decfd7f Compare September 19, 2025 23:48
Comment thread local_hooks/app_tests/json_tests.py Resolved
@tapishj-splunk
tapishj-splunk force-pushed the tapishj/fix-sdkify-pre-commit branch from decfd7f to f116a51 Compare September 20, 2025 00:13
Comment thread local_hooks/app_tests/code_tests.py Resolved
Comment thread local_hooks/generate_notice.py Resolved
@tapishj-splunk
tapishj-splunk force-pushed the tapishj/fix-sdkify-pre-commit branch 5 times, most recently from 0345f80 to 2297c1a Compare September 22, 2025 17:37
@tapishj-splunk
tapishj-splunk force-pushed the tapishj/fix-sdkify-pre-commit branch 3 times, most recently from f13bfa0 to 6de2923 Compare September 22, 2025 18:14
Comment thread local_hooks/helpers.py Resolved
@tapishj-splunk
tapishj-splunk force-pushed the tapishj/fix-sdkify-pre-commit branch 3 times, most recently from 67471c1 to 89a85bd Compare September 22, 2025 19:58
@tapishj-splunk
tapishj-splunk force-pushed the tapishj/fix-sdkify-pre-commit branch from 89a85bd to 539e6f2 Compare September 22, 2025 20:06
@tapishj-splunk
tapishj-splunk force-pushed the tapishj/fix-sdkify-pre-commit branch from 0b3ddb9 to d6e97ff Compare September 22, 2025 20:19
@tapishj-splunk
tapishj-splunk force-pushed the tapishj/fix-sdkify-pre-commit branch 6 times, most recently from 8962e59 to 1720eff Compare September 23, 2025 20:21
@tapishj-splunk
tapishj-splunk force-pushed the tapishj/fix-sdkify-pre-commit branch from 1720eff to dc780fe Compare September 23, 2025 20:26
@tapishj-splunk
tapishj-splunk merged commit bf62ce3 into main Sep 30, 2025
4 checks passed
@tapishj-splunk
tapishj-splunk deleted the tapishj/fix-sdkify-pre-commit branch September 30, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants