Skip to content

Use zip instead of deprecated zip-extract #2294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cbandy wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Use zip instead of deprecated zip-extract #2294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
034805a
Fix compilation error on rustc 1.90.0 aarch64-unknown-linux-gnu
cbandy May 27, 2026
a0c50d6
Use zip instead of deprecated zip-extract
cbandy May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 1 addition & 12 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion cargo-pgrx/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ tar = "0.4.44"
ureq = { version = "3.0.10", default-features = false, features = ["gzip", "platform-verifier", "rustls"] }
url.workspace = true
which = "7.0.3"
zip-extract = "0.2.2"
zip = "5.1.1"
postgres = { version = "0.19.10", features = ["with-serde_json-1", "with-uuid-1"] }
uuid = { version = "1.16.0", features = ["v4"] }

Expand Down
2 changes: 1 addition & 1 deletion cargo-pgrx/src/command/init.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,7 @@ fn untar(bytes: &[u8], pgrxdir: &Path, pg_config: &PgConfig, init: &Init) -> eyr
{
// it's a zip download from EDB
use std::io::Cursor;
zip_extract::extract(Cursor::new(bytes), &unpackdir, false)?;
zip::ZipArchive::new(Cursor::new(bytes))?.extract(&unpackdir)?;
} else {
let mut tar_decoder = Archive::new(BzDecoder::new(bytes));
tar_decoder.unpack(&unpackdir)?;
Expand Down
4 changes: 2 additions & 2 deletions pgrx-examples/hooks/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ unsafe fn register_hooks() {
#[pg_guard]
unsafe extern "C-unwind" fn process_utility_hook(
pstmt: *mut pg_sys::PlannedStmt,
query_string: *const i8,
query_string: *const core::ffi::c_char,
context: pg_sys::ProcessUtilityContext::Type,
params: *mut pg_sys::ParamListInfoData,
query_env: *mut pg_sys::QueryEnvironment,
Expand Down Expand Up @@ -144,7 +144,7 @@ unsafe fn register_hooks() {
#[pg_guard]
unsafe extern "C-unwind" fn process_utility_hook(
pstmt: *mut pg_sys::PlannedStmt,
query_string: *const i8,
query_string: *const core::ffi::c_char,
read_only_tree: bool,
context: pg_sys::ProcessUtilityContext::Type,
params: *mut pg_sys::ParamListInfoData,
Expand Down
Loading