fix(sharding): prevent shard filters from matching classes outside their partition - #1884
Open
MrPunyapal wants to merge 2 commits into
Open
fix(sharding): prevent shard filters from matching classes outside their partition#1884MrPunyapal wants to merge 2 commits into
MrPunyapal wants to merge 2 commits into
Conversation
MrPunyapal
force-pushed
the
fix/shard-filter-class-boundary
branch
from
August 27, 2026 16:30
3fd33cf to
4c96d43
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Description:
Shard filters are matched by PHPUnit as unanchored regular expressions against
Class::method, so any class whose name started with another class assigned to a different shard also ran there (e.g.Tests\Feature\AftermatchingTests\Feature\AfterAll). Splitting Pest's own suite 1/2 executed 218 tests in both shards; with this change, zero.The generated filter now requires
::right after each class path. A class that is also the prefix of another class in the same shard keeps its own alternative.Before:
Tests\\Feature\\(After|AfterAll)→ after:Tests\\Feature\\(After(?=::)|AfterAll(?=::))