fix(tia): exclude vendor from xdebug coverage while recording - #1867
Open
lazerg wants to merge 1 commit into
Open
fix(tia): exclude vendor from xdebug coverage while recording#1867lazerg wants to merge 1 commit into
lazerg wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Description:
The recorder starts Xdebug coverage with no filter, so every executed line of
vendor/is traced and then dropped by the scope check inendTest(). The pcov path in the same class already narrows the file list before it collects anything.Recorder::activate()now callsxdebug_set_filter()with the directoriesSourceScopetreats as noise (vendor,node_modules, the cache directories,storage/framework), so Xdebug never instruments them. Xdebug only honours the filter for files compiled after it is set, which is why the call sits inactivate()and not next toxdebug_start_code_coverage()inbeginTest(). Every prefix ends with a separator, otherwisevendorwould also match a sibling such asvendored.The scope check after
xdebug_get_code_coverage()stays, since the filter is a prefilter and not a replacement for it. The recorded graph is unchanged:tests/Features/Tiapasses in full with Xdebug 3.5.3 in coverage mode.I added a unit file for
noisePaths()and bumped both suite tallies by hand, sincecomposer update:snapshotswould have baked in theTests\Unit\Support\Backtracefailure I get on a clean5.xhere.Related:
Fixes #1865