fix: preserve the global afterAll hook until class teardown - #1743
Closed
lazerg wants to merge 1 commit into
Closed
Conversation
1 task
Contributor
Author
|
Hi @nunomaduro, just checking back on this one. It's been about three weeks since I flagged it. The global afterAll hook does not run right now. Let me know if you need anything from me to move it forward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Description:
A global
afterAll()hook (registered viauses()/pest()) never runs, whilebeforeAll,beforeEachandafterEachwork.beforeAllis consumed insetUpBeforeClassbefore any test runs, but the last test'stearDownflushes the static$__afterAllbeforetearDownAfterClassreads it, so the global afterAll silently no-ops. This captures the hook insetUpBeforeClasswhile it's still set and uses that copy at teardown.Related:
Closes #1694