ci: simplify npm publish step for Trusted Publishing (OIDC)#129
Closed
dshoen619 wants to merge 2 commits into
Closed
ci: simplify npm publish step for Trusted Publishing (OIDC)#129dshoen619 wants to merge 2 commits into
dshoen619 wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Simplifies the GitHub Actions release workflow for publishing the Node SDK to npm by replacing the prerelease/standard branching publish logic with a single npm publish, aligned with npm Trusted Publishing (OIDC) authentication.
Changes:
- Replaced conditional prerelease (
--tag rc) vs stable publish logic with a singlenpm publish. - Removed explicit
--access publicfrom the publish command.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
101
to
+102
| - name: Publish package to NPM | ||
| run: | | ||
| if [[ "${{ github.event.release.prerelease }}" == "true" ]]; then | ||
| echo "Publishing as a release candidate (rc)..." | ||
| npm publish --access public --tag rc | ||
| else | ||
| echo "Publishing as the latest release..." | ||
| npm publish --access public | ||
| fi | ||
| run: npm publish |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Publish package to NPMstep innode_sdk_publish.yamlto a singlenpm publishcommand.--tag rcbranching and the explicit--access publicflag, relying on npm Trusted Publishing (OIDC) for authentication.Context
Follow-up to the migration to npm Trusted Publishing (PER-15197). Authentication is handled via the job's
id-token: writepermission plus a Trusted Publisher configured on npmjs.com — noNPM_TOKENneeded.Test plan
🤖 Generated with Claude Code