Log broadcast listener failures#910
Conversation
✅ Deploy Preview for opal-docs canceled.
|
|
Added a small unit test file covering the broadcast listener done-callback behavior:
Local verification run: I could not run the pytest target locally because this environment does not have pytest installed, but the test is isolated and uses monkeypatching only around the imported module logger and shutdown method. |
|
Thanks for this and for the clean, well-tested patch, @JjCyberz. Unfortunately the linked issue #716 was closed as stale by a maintainer ("This issue is stale and the bounty is more than a year old. Closing it."), so we won't be merging the competing bounty-claim PRs for it. There are also other open PRs targeting the same issue (#728, #874, #882, #884), and the broadcast reader-task health path is being reworked more broadly in the broadcaster reconnect/healthcheck effort (#915), which will cover this error surface. For those reasons we're going to close this PR. We appreciate the contribution and the careful handling of the CancelledError and result-read edge cases. |
Fixes #716.
When the server statistics broadcast listener task exits, OPAL currently only triggers a worker shutdown. If the task failed because the broadcast URI host cannot be resolved, the useful exception stays buried in dependency DEBUG output and no OPAL server ERROR log points at the broadcast URI.
This PR replaces the anonymous done callback with a named handler that:
Validation:
Bounty note:
/claim #716