Skip to content

Update yarn lockfile to pass asset generation - #2379

Merged
RaghavsBrowserStack merged 7 commits into
masterfrom
intellistory_beta
Aug 11, 2026
Merged

Update yarn lockfile to pass asset generation#2379
RaghavsBrowserStack merged 7 commits into
masterfrom
intellistory_beta

Conversation

@RaghavsBrowserStack

Copy link
Copy Markdown
Contributor

The lockfile in master is currently out of sync due to intellistory changes. This pr fixes that

RaghavsBrowserStack and others added 7 commits August 10, 2026 18:34
packages/core/.test-archive-mixed and .test-archive-symlink were leftovers
from a local unit-test run that got picked up by the version-bump commit.
.test-archive-symlink/linked.json is an absolute symlink into a developer's
home directory, so it dangles on a fresh CI checkout and makes
`babel packages -d build` (build_cjs) fail with ENOENT, breaking the
Build Executables job.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
d302b09 deleted these on this branch, but master picked up the same
accidental add in d663543 (bump version, #2377), so merging master back in
(2405903) restored them and left PR #2378 with an empty diff.

packages/core/.test-archive-symlink/linked.json is an absolute symlink into a
developer's home directory. It dangles on a fresh CI checkout, so
`babel packages -d build` (build_cjs) fails with ENOENT and takes down the
Build Executables job.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The lockfile block added in 8311242 (IntelliStory, #2339) was edited by hand
rather than regenerated, leaving it inconsistent with the dependency graph:

  - @types/node@* had no entry, though @types/cacheable-request, @types/keyv,
    @types/responselike and @types/yauzl all require it
  - get-stream@^5.1.0 had no entry, though cacheable-request@^7.0.2 requires it
  - @types/yauzl@^2.9.1 was orphaned — nothing referenced it

So `yarn` on a clean CI checkout resolved the two missing descriptors, pruned
the orphan and rewrote the file. That left the working tree dirty, and
`lerna publish from-package` aborted with EUNCOMMIT (M yarn.lock), failing the
Release job.

Regenerated with a plain `yarn install`. `yarn install --frozen-lockfile` is
now a no-op, so the release checkout stays clean.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@RaghavsBrowserStack

Copy link
Copy Markdown
Contributor Author

Claude Code PR Review

PR: #2379Head: c8f17c4Reviewers: stack:code-reviewer

Summary

Lockfile-only change (yarn.lock, +35/-8) that repairs a yarn.lock left internally inconsistent by the hand-edited IntelliStory merge — adding the missing @types/node@* and get-stream@^5.1.0 resolutions (plus their cascading sub-deps pump, end-of-stream@^1.1.0, undici-types@~8.3.0, once@^1.3.1) and pruning the orphaned @types/yauzl@^2.9.1 entry.

Review Table

Priority Category Check Status Notes
High Security No hardcoded secrets or credentials Pass No code changed; lockfile contains only registry URLs and integrity hashes.
High Security Authentication/authorization checks present N/A No auth surface touched.
High Security Input validation and sanitization N/A No input-handling code touched.
High Security No IDOR — resource ownership validated N/A No resource access code touched.
High Security No SQL injection (parameterized queries) N/A No database code touched.
High Correctness Logic is correct, handles edge cases Pass Verified every added entry closes a real gap: @types/cacheable-request, @types/keyv, @types/responselike all declare "@types/node" "*" with no resolution in master; cacheable-request@^7.0.2 declares get-stream "^5.1.0" with no resolution in master. once@^1.3.1 correctly merged into the existing 1.4.0 group.
High Correctness Error handling is explicit, no swallowed exceptions N/A No executable code.
High Correctness No race conditions or concurrency issues N/A No concurrent code.
Medium Testing New code has corresponding tests N/A Lockfile regeneration; nothing to unit test.
Medium Testing Error paths and edge cases tested N/A See above.
Medium Testing Existing tests still pass (no regressions) Pass All 47 GitHub checks pass on c8f17c4 (Build, Lint, Regression, typecheck, and every per-package test job).
Medium Performance No N+1 queries or unbounded data fetching N/A No data-access code.
Medium Performance Long-running tasks use background jobs N/A Not applicable.
Medium Quality Follows existing codebase patterns Pass Standard yarn v1 lockfile format; entries carry both resolved and integrity.
Medium Quality Changes are focused (single concern) Pass Exactly one file, one concern — lockfile consistency. Earlier stray-fixture commits on the branch were already reverted before this head.
Low Quality Meaningful names, no dead code Pass Orphaned @types/yauzl@^2.9.1 removed — confirmed nothing in root or packages/* package.json, nor any lockfile dependencies: block, references it.
Low Quality Comments explain why, not what N/A Generated file.
Low Quality No unnecessary dependencies added Pass No package.json changed; all added lockfile entries are transitive resolutions already required by existing declared ranges.

Findings

No Fail rows and no Critical/High/Medium findings. Two informational notes, neither introduced by this PR:

  • File: yarn.lock (@types/node@* entry)

  • Severity: Low

  • Reviewer: stack:code-reviewer

  • Issue: @types/node@* resolves to 26.1.2, a very new major, because the transitively-declared range is unpinned *. Multiple @types/node majors now coexist in the tree (14.14.22, 26.1.2, plus >= ranges). Ambient global type declarations across differing majors can in principle produce tsc errors.

  • Suggestion: No action needed — the unpinned * range is pre-existing transitive behavior, and test:types passes in CI on this head. If type-stacking ever bites, add an explicit @types/node resolution to pin it.

  • File: yarn.lock (new entries use registry.yarnpkg.com, surrounding entries use registry.npmjs.org)

  • Severity: Low

  • Reviewer: stack:code-reviewer

  • Issue: Mixed registry hostnames in resolved URLs (120 yarnpkg vs 1120 npmjs at head).

  • Suggestion: Cosmetic only. The mix already exists in master and reflects different yarn-version writers over the file's history; both hosts serve identical tarballs and integrity hashes are present. Not worth churning the file to normalize.

Verification performed beyond the diff: dependency-graph consistency check over the resulting lockfile (every declared name@range spec has a matching resolution entry), @types/yauzl orphan status confirmed by grep across all package.json files and lockfile dependency blocks, and yarn install --frozen-lockfile usage located in .github/workflows/version-bump.yml:41 — the job whose failure this PR fixes.


Verdict: PASS

@RaghavsBrowserStack
RaghavsBrowserStack merged commit b913177 into master Aug 11, 2026
48 checks passed
@RaghavsBrowserStack
RaghavsBrowserStack deleted the intellistory_beta branch August 11, 2026 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants