PMM-14969: UI upgrade removal#5394
Open
fabio-silva wants to merge 6 commits into
Open
Conversation
fabio-silva
requested review from
4nte,
JiriCtvrtka,
Copilot,
matejkubinec and
mattiasimonato
and removed request for
a team,
4nte,
JiriCtvrtka and
Nailya
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v3 #5394 +/- ##
==========================================
- Coverage 43.22% 43.19% -0.04%
==========================================
Files 413 413
Lines 42279 42279
==========================================
- Hits 18277 18263 -14
- Misses 22134 22149 +15
+ Partials 1868 1867 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the UI-driven PMM upgrade flow (and related Watchtower plumbing) and replaces the “Update now” action with a link to the official upgrade documentation, while cleaning up development/build tooling that previously supported Watchtower-based updates.
Changes:
- Replaced the in-UI “Update now” action with an external link to upgrade documentation.
- Removed update-progress/update-log UI components and associated hooks/types/messages.
- Removed Watchtower configuration from compose files, installer script (
get-pmm.sh), packer/ansible podman setup, and env examples; added a new Grafana provisioning file for dashboards dev.
Reviewed changes
Copilot reviewed 29 out of 31 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ui/docker-compose.yml | Removes the Watchtower service from the UI dev compose stack. |
| ui/apps/pmm/src/pages/updates/update-log/UpdateLog.types.ts | Deletes UpdateLog props type (UpdateLog feature removal). |
| ui/apps/pmm/src/pages/updates/update-log/UpdateLog.tsx | Deletes UpdateLog modal component (UpdateLog feature removal). |
| ui/apps/pmm/src/pages/updates/update-log/UpdateLog.messages.ts | Deletes UpdateLog UI strings. |
| ui/apps/pmm/src/pages/updates/update-log/UpdateLog.hooks.ts | Deletes polling hook for update logs. |
| ui/apps/pmm/src/pages/updates/update-log/update-log-content/UpdateLogContent.types.ts | Deletes UpdateLogContent props type. |
| ui/apps/pmm/src/pages/updates/update-log/update-log-content/UpdateLogContent.tsx | Deletes UpdateLogContent rendering component. |
| ui/apps/pmm/src/pages/updates/update-log/update-log-content/index.ts | Removes barrel export for UpdateLogContent. |
| ui/apps/pmm/src/pages/updates/update-log/index.ts | Removes barrel export for UpdateLog. |
| ui/apps/pmm/src/pages/updates/update-in-progress-card/UpdateInProgressCard.types.tsx | Deletes UpdateInProgressCard props type (in-progress UI removal). |
| ui/apps/pmm/src/pages/updates/update-in-progress-card/UpdateInProgressCard.tsx | Deletes in-progress update card UI (in-app upgrade flow removal). |
| ui/apps/pmm/src/pages/updates/update-in-progress-card/UpdateInProgressCard.messages.ts | Deletes in-progress update card strings. |
| ui/apps/pmm/src/pages/updates/update-in-progress-card/update-progress/UpdateProgress.types.ts | Deletes UpdateProgress props type. |
| ui/apps/pmm/src/pages/updates/update-in-progress-card/update-progress/UpdateProgress.tsx | Deletes update progress UI widget. |
| ui/apps/pmm/src/pages/updates/update-in-progress-card/update-progress/UpdateProgress.messages.ts | Deletes update progress strings. |
| ui/apps/pmm/src/pages/updates/update-in-progress-card/index.ts | Removes barrel export for UpdateInProgressCard. |
| ui/apps/pmm/src/pages/updates/update-card/UpdateCard.tsx | Removes start-update logic and renders a docs link button instead. |
| ui/apps/pmm/src/pages/updates/update-card/UpdateCard.messages.ts | Updates button text key; retains other messages. |
| ui/apps/pmm/src/pages/updates/update-card/UpdateCard.constants.ts | Replaces old deprecation links with a single upgrade docs URL constant. |
| get-pmm.sh | Removes Watchtower token option and Watchtower container/token setup logic. |
| docker-compose.dev.yml | Removes Watchtower service/profile from the main dev compose stack. |
| dashboards/pmm-app/provisioning-dev.yml | Adds a new Grafana provisioning definition for dashboards in dev. |
| build/packer/pmm.json | Removes Watchtower image variable and stops passing it to Ansible. |
| build/packer/ansible/roles/podman-setup/templates/watchtower.service | Deletes Watchtower systemd unit template. |
| build/packer/ansible/roles/podman-setup/templates/watchtower.env | Deletes Watchtower env template. |
| build/packer/ansible/roles/podman-setup/templates/pmm-server.env | Removes Watchtower-related env vars from podman PMM env template. |
| build/packer/ansible/roles/podman-setup/tasks/main.yml | Removes SELinux/watchtower setup and service enablement tasks. |
| build/Makefile | Removes Watchtower image variable and packer var wiring. |
| AGENTS.md | Updates dev compose description to remove Watchtower mention. |
| .env.example | Removes Watchtower example configuration block. |
| .env.dev.example | Removes Watchtower dev example configuration block. |
Comments suppressed due to low confidence (1)
ui/apps/pmm/src/pages/updates/update-card/UpdateCard.messages.ts:16
howToUpdateDocs: 'How to update docs'is ambiguous (it reads like documentation about updating documentation) and thedeprecationcopy below mentions removal in PMM 3.9.0 but the UI upgrade flow has already been removed in this PR. Consider renaming the button label to something like “View upgrade documentation” (or similar) and deleting/updating the now-unuseddeprecationmessage block to avoid stale strings lingering in the codebase.
howToUpdateDocs: 'How to update docs',
error: 'There was a problem during the update',
deprecation: {
heading: 'UI upgrades deprecated',
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fabio-silva
force-pushed
the
PMM-14969-ui-upgrade-removal
branch
from
eb1a26e to
44c1002
Compare
Contributor
matejkubinec
left a comment
matejkubinec
left a comment
There was a problem hiding this comment.
@fabio-silva good from the FE side, it would be good to receive approval feedback on the other changes (build/get-pmm/etc.)
| 'https://per.co.na/pmm/upgrade-podman'; | ||
| export const DEPRECATION_HELM_UPGRADE_HREF = | ||
| 'https://per.co.na/pmm/upgrade-helm'; | ||
| export const UPGRADE_DOCS_HREF = 'https://docs.percona.com/percona-monitoring-and-management/3/pmm-upgrade/index.html'; No newline at end of file |
Contributor
There was a problem hiding this comment.
@catalinaadam it would be good to have a shortlink here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PMM-14969
Replace "Upgrade now" with documentation reference