PMM-15076 Fix NUMA Details dashboard to show all NUMA nodes by default#5389
Draft
ondrejpatocka wants to merge 2 commits into
Draft
PMM-15076 Fix NUMA Details dashboard to show all NUMA nodes by default#5389ondrejpatocka wants to merge 2 commits into
ondrejpatocka wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v3 #5389 +/- ##
==========================================
- Coverage 43.20% 43.05% -0.15%
==========================================
Files 413 543 +130
Lines 42302 44650 +2348
Branches 0 590 +590
==========================================
+ Hits 18278 19226 +948
- Misses 22157 23548 +1391
- Partials 1867 1876 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
nodevariable shipped as single-value, hidden, defaulting to0- so per-node rows(
"repeat": "node") only rendered for Node 0 on multi-NUMA hosts.Changes (
dashboards/OS/NUMA_Details.json)nodevariable →multi: true,includeAll: true,hide: 0, default$__all(now consistent with the sibling
zonevariable).node="$node"→node=~"$node"to match the regex substitutionproduced by a multi-value variable.