Move isFirstRedo state to undo manager#2017
Open
MrStevns wants to merge 1 commit into
Open
Conversation
Because it causes issues that each undo/redo command owns the isFirstRedo when parent is ignored and thus doesn't trigger redo on the child.
MrStevns
changed the title
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because it causes issues that each undo/redo command owns the isFirstRedo when parent is ignored. The consequence of this is that later when the you perform a redo that triggers a child command, the command will be ignored because it hasn't been called previously.
To recap why we do this:
QUndoCommand works in the way where pushing a command onto the stack, triggers redo immediately and that doesn't work with our current architecture, so to prevent triggering the same action twice, we skip the first redo.