TimeControls in Timeline titlebar area#2006
Open
MrStevns wants to merge 10 commits into
Open
Conversation
- TimeControls are not centered - New time code icon - Buttons changed to QToolButton
To prevent micro jitter.
- Possible to enable/disable timecodes in general - Possible to show frames next to time code
chchwy
force-pushed
the
timecode-ui-widget
branch
from
07b5904 to
00d25bc
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it looks like
Moving the time controls into the title bar area also meant allowing us to find a better placement for the time code counter. It was quite cramped on the timeline before. With the additional space now, I've put it next to the actual playback controls and made some improvements along the way. Among those improves are:
New time code controls component, replacing the old qmenu.
The primary motivator here was to allow you to change both the timecode and frame counter in one go, rather than selecting one thing, close the menu and then open the menu again to enable the other setting. The new widget also allows for more controls in the future, should that be needed.
Added time code icon
The time code is now displayed next to the playback buttons
The time code is now mono spaced, so there's no longer horizontal movement when counting.
Raw frame counter can now be displayed separately from the time code.
We now store 3 settings instead of one.
Other changes
Note: I have not done migration from the old value SETTING_TIMECODE_TEXT to the new one.