Store nightly builds as artifacts#1719
Merged
Merged
Conversation
Member
|
How many changes are required in order to make it work for our forks? if possible we'll need to update https://github.com/pencil2d/pencil/wiki/CI-build-and-deploy too or will it simply work out of the box? When that's said, I welcome these changes, a simpler CI pipeline is always nice |
Member
Author
|
It should work out of the box, with no setup needed. That was actually one of my motivations for this :) |
MrStevns
approved these changes
Jul 3, 2022
MrStevns
left a comment
Member
There was a problem hiding this comment.
Changes look good to me, well done 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the thing I proposed on Discord earlier this month, so I’ll repost what I wrote there:
For the API workaround that I mentioned I created a little service at get.pencil2d.org which uses the GitHub API to generate a download URL (which is valid for one minute) and returns a redirect to that URL. A link to that service is automatically generated in the summary for each job, so the builds can be easily downloaded even without having to sign in. I considered automatically adding comments on PRs as well (as suggested in #1152), but unfortunately that’s a bit more tricky due to API permissions and the fact that you need to aggregate the job results first, so I’ve left that for later. I did however adjust the nightly build download page on our website as necessary, for which I’ve created a companion PR at pencil2d/pencil2d.github.io#25.