Skip to content

Allow reference model type field to be maybe type #12

Description

@pbomb

When defining a model type with a property of another model type like this:

export type MyModelType {
  field: OtherModelType,
};

the fromJS function for MyModelType calls the fromJS from the Other model class. However, if field is defined as a maybe type (e.g. field: ?OtherModelType), the codemod doesn't recognize it as a model type or do anything in the fromJS function.

The correct behavior would be to still have the fromJS function contain code like the following, taking the null/undefined case into account:

  state.field = state.field == null ? state.field : Other.fromJS(state.field);

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions