Repository navigation
sys.stderr replace mock with io.StringIO - #1717
Merged
Merged
Conversation
Python 3.15 does some formatting on sys.stderr for argparse and this doesn't work with a Mock object (it tries call fileno and expects an integer). Use io.StringIO instead, I think it's only used for supressing stderr.
Owner
|
It looks safe to me but I'll fire up a copilot review just in case as I'm no expert. thanks for pushing this project :) |
There was a problem hiding this comment.
Pull request overview
Updates the argparse unit test helper to patch sys.stderr with a real file-like object rather than a Mock, avoiding failures in newer Python versions where argparse expects sys.stderr.fileno() to behave like a real stream.
Changes:
- Replace
mock.Mock()withio.StringIO()when patchingsys.stderrduringArgumentParser.parse_args(). - Add the required
ioimport in the test module.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python 3.15 does some formatting on sys.stderr for argparse and this doesn't work with a Mock object (it tries call fileno and expects an integer).
Use io.StringIO instead, I think it's only used for supressing stderr.