Repository navigation
feat: add validation of ranged and stepped numerical inputs #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
f95c8e7
feat: add validation of ranged numerical inputs
jpbrodrick89 60a2676
linting :lipstick:
jpbrodrick89 24220ba
rename fields and nits
jpbrodrick89 6301462
nest NumberConstraints TypedDict
jpbrodrick89 0de9188
add missing dot
jpbrodrick89 fcec2d2
add missing_cast_type
jpbrodrick89 a38442f
add some constraints to example tesseracts
jpbrodrick89 c60741a
limitation for UI validation
jpbrodrick89 cf0463b
added punctuation to doc string
jpbrodrick89 7b82d1d
default step to none
jpbrodrick89 cb584ec
test step behaviour with increment
jpbrodrick89 20221fb
Merge branch 'main' into jpb/ranged-inputs
jacanchaplais File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,113 @@ | ||
| [{"type":"string","title":"Name","description":"Name of the person you want to greet.","ancestors":["name"],"default":"John Doe"},{"type":"integer","title":"Age","description":"Age of person in years.","ancestors":["age"],"default":30},{"type":"number","title":"Height","description":"Height of person in cm.","ancestors":["height"],"default":175.0},{"type":"boolean","title":"Alive","description":"Whether the person is (currently) alive.","ancestors":["alive"],"default":true},{"type":"number","title":"Weight","description":"The person's weight in kg.","ancestors":["weight"],"default":null},{"type":"array","title":"Leg Lengths","description":"The length of the person's left and right legs in cm.","ancestors":["leg_lengths"]},{"type":"composite","title":"Hobby","description":"The person's only hobby.","ancestors":["hobby"]},{"type":"string","title":"Name","description":"Name of the activity.","ancestors":["hobby","name"],"default":""},{"type":"boolean","title":"Active","description":"Does the person actively engage with it?","ancestors":["hobby","active"],"default":null},{"type":"integer","title":"Experience","description":"Experience practising it in years.","ancestors":["hobby","experience"],"default":null}] | ||
| [ | ||
| { | ||
| "type": "string", | ||
| "title": "Name", | ||
| "description": "Name of the person you want to greet.", | ||
| "ancestors": [ | ||
| "name" | ||
| ], | ||
| "default": "John Doe" | ||
| }, | ||
| { | ||
| "type": "integer", | ||
| "title": "Age", | ||
| "description": "Age of person in years.", | ||
| "ancestors": [ | ||
| "age" | ||
| ], | ||
| "default": 30, | ||
| "number_constraints": { | ||
| "max_value": 125, | ||
| "min_value": 0, | ||
| "step": null | ||
| } | ||
| }, | ||
| { | ||
| "type": "number", | ||
| "title": "Height", | ||
| "description": "Height of person in cm.", | ||
| "ancestors": [ | ||
| "height" | ||
| ], | ||
| "default": 175, | ||
| "number_constraints": { | ||
| "max_value": 300, | ||
| "min_value": 0, | ||
| "step": 0.1 | ||
| } | ||
| }, | ||
| { | ||
| "type": "boolean", | ||
| "title": "Alive", | ||
| "description": "Whether the person is (currently) alive.", | ||
| "ancestors": [ | ||
| "alive" | ||
| ], | ||
| "default": true | ||
| }, | ||
| { | ||
| "type": "number", | ||
| "title": "Weight", | ||
| "description": "The person's weight in kg.", | ||
| "ancestors": [ | ||
| "weight" | ||
| ], | ||
| "default": null, | ||
| "number_constraints": { | ||
| "max_value": null, | ||
| "min_value": 0, | ||
| "step": null | ||
| } | ||
| }, | ||
| { | ||
| "type": "array", | ||
| "title": "Leg Lengths", | ||
| "description": "The length of the person's left and right legs in cm.", | ||
| "ancestors": [ | ||
| "leg_lengths" | ||
| ] | ||
| }, | ||
| { | ||
| "type": "composite", | ||
| "title": "Hobby", | ||
| "description": "The person's only hobby.", | ||
| "ancestors": [ | ||
| "hobby" | ||
| ] | ||
| }, | ||
| { | ||
| "type": "string", | ||
| "title": "Name", | ||
| "description": "Name of the activity.", | ||
| "ancestors": [ | ||
| "hobby", | ||
| "name" | ||
| ], | ||
| "default": "" | ||
| }, | ||
| { | ||
| "type": "boolean", | ||
| "title": "Active", | ||
| "description": "Does the person actively engage with it?", | ||
| "ancestors": [ | ||
| "hobby", | ||
| "active" | ||
| ], | ||
| "default": null | ||
| }, | ||
| { | ||
| "type": "integer", | ||
| "title": "Experience", | ||
| "description": "Experience practising it in years.", | ||
| "ancestors": [ | ||
| "hobby", | ||
| "experience" | ||
| ], | ||
| "default": null, | ||
| "number_constraints": { | ||
| "max_value": 120, | ||
| "min_value": 0, | ||
| "step": null | ||
| } | ||
| } | ||
| ] |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.