Repository navigation
fix: escape quotes and backslashes in titles and string defaults - #201
Open
singhharsh1708 wants to merge 1 commit into
Open
singhharsh1708 wants to merge 1 commit into
singhharsh1708 wants to merge 1 commit into
Conversation
singhharsh1708
requested review from
apaleyes,
dionhaefner and
jacanchaplais
as code owners
November 3, 2026 19:39
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #201 +/- ##
=======================================
Coverage 86.64% 86.64%
=======================================
Files 5 5
Lines 322 322
Branches 36 36
=======================================
Hits 279 279
Misses 39 39
Partials 4 4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant issue or PR
Follow-up to #197, which escaped descriptions.
Description of changes
Field titles, string defaults, UDF titles and the page title were still written into the generated app's string literals as-is, so a
"or\in any of them broke the app (SyntaxError) or changed the text. They now go through the same escaping as descriptions, moved into anescape_strmacro.Testing done
New test renders a string field and a number field with a quote or backslash in the title and default, parses the app and checks the text survives. It fails on main and passes with the fix.