Repository navigation
fix: escape quotes and backslashes in field descriptions - #197
Merged
apaleyes merged 2 commits intoNov 3, 2026
Merged
Conversation
singhharsh1708
requested review from
apaleyes,
dionhaefner and
jacanchaplais
as code owners
November 3, 2026 11:22
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #197 +/- ##
=======================================
Coverage 86.64% 86.64%
=======================================
Files 5 5
Lines 322 322
Branches 36 36
=======================================
Hits 279 279
Misses 39 39
Partials 4 4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
apaleyes
reviewed
Nov 3, 2026
apaleyes
left a comment
Contributor
There was a problem hiding this comment.
thanks @singhharsh1708 ! one thing to clarify below
apaleyes
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant issue or PR
Follows #128, which added multiline descriptions.
Description of changes
The
multilinemacro wraps each description line in"..."without escaping it, so a description with a double quote gives an app that does not compile (SyntaxError ... "The "a" coefficient",), and a backslash is mangled (\thetabecomes a tab and "heta") or breaks it (\x). The macro now escapes backslashes and double quotes.String defaults and titles with
"break the same way; this PR only covers descriptions.Testing done
description='The "a" coefficient'and one with a backslash: the generated app fails to parse on main and compiles here, with the help text unchanged.tests/test_parse.pypasses.