Repurpose DNS domains with match/search policy#339
Merged
Conversation
keeshux
force-pushed
the
feature/dns-match-domains
branch
from
f5c6b10 to
acb4995
Compare
keeshux
changed the title
keeshux
changed the title
keeshux
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steps:
domainNameandsearchDomainsintodomainsin the DNSModule builder.isFirstDomainPrimaryflag.domainPolicyfield to fine-tune the semantics of the domains listThe default policy, when unset, is to use the list of domains for both:
"Match" and "Search" behavior can be picked selectively by setting an explicit policy, but the common user expectation for split DNS setups is that both semantics apply. If the VPN is the default gateway, match domains are ignored anyway.
Apply part of the reasoning behind WireGuard/wireguard-apple#11, but make it about NE rather than WireGuard, because it's a DNS concern.
Be defensive about DoH/DoT for now, as I haven't tested if .matchDomains is still effective with empty bootstrap DNS servers. In that case, we clear the field to avoid known quirks with Network Extension.