Skip to content

fix: _Installation update crashes or orphans row when clearing installationId #10455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AdrianCurtin wants to merge 3 commits into
base: alpha
Choose a base branch
from
+229 −0
Open

fix: _Installation update crashes or orphans row when clearing installationId #10455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
36b1fae
fix: _Installation update crashes or orphans row when clearing instal…
AdrianCurtin May 4, 2026
5289c0b
Merge branch 'alpha' into fix_installation_id_error
AdrianCurtin May 21, 2026
d0fe8e9
Reject non-string installationId; add tests
AdrianCurtin May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
196 changes: 196 additions & 0 deletions spec/ParseInstallation.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -544,6 +544,202 @@ describe('Installations', () => {
});
});

it('update fails to clear installationId via Delete op', done => {
const installId = '12345678-abcd-abcd-abcd-123456789abc';
const input = {
installationId: installId,
deviceType: 'ios',
};
rest
.create(config, auth.nobody(config), '_Installation', input)
.then(() => database.adapter.find('_Installation', installationSchema, {}, {}))
.then(results => {
expect(results.length).toEqual(1);
return rest.update(
config,
auth.nobody(config),
'_Installation',
{ objectId: results[0].objectId },
{ installationId: { __op: 'Delete' } }
);
})
.then(() => {
fail('Updating the installation should have failed.');
done();
})
.catch(error => {
expect(error.code).toEqual(136);
done();
});
});

it('update fails to clear installationId via null', done => {
const installId = '12345678-abcd-abcd-abcd-123456789abc';
const input = {
installationId: installId,
deviceType: 'ios',
};
rest
.create(config, auth.nobody(config), '_Installation', input)
.then(() => database.adapter.find('_Installation', installationSchema, {}, {}))
.then(results => {
expect(results.length).toEqual(1);
return rest.update(
config,
auth.nobody(config),
'_Installation',
{ objectId: results[0].objectId },
{ installationId: null }
);
})
.then(() => {
fail('Updating the installation should have failed.');
done();
})
.catch(error => {
expect(error.code).toEqual(136);
done();
});
});

it('create fails when installationId is the Delete op (no real ID provided)', done => {
const input = {
installationId: { __op: 'Delete' },
deviceType: 'ios',
};
rest
.create(config, auth.nobody(config), '_Installation', input)
.then(() => {
fail('Creating the installation should have failed.');
done();
})
.catch(error => {
expect(error.code).toEqual(135);
done();
});
});

it('create fails when installationId is null (no real ID provided)', done => {
const input = {
installationId: null,
deviceType: 'ios',
};
rest
.create(config, auth.nobody(config), '_Installation', input)
.then(() => {
fail('Creating the installation should have failed.');
done();
})
.catch(error => {
expect(error.code).toEqual(135);
done();
});
Comment on lines +547 to +636
});

it('create fails when installationId is a non-string object', done => {
const input = {
installationId: { foo: 'bar' },
deviceType: 'ios',
};
rest
.create(config, auth.nobody(config), '_Installation', input)
.then(() => {
fail('Creating the installation should have failed.');
done();
})
.catch(error => {
expect(error.code).toEqual(Parse.Error.INVALID_JSON);
done();
});
});

it('update fails when installationId is a non-string object', done => {
const installId = '12345678-abcd-abcd-abcd-123456789abc';
const input = {
installationId: installId,
deviceType: 'ios',
};
rest
.create(config, auth.nobody(config), '_Installation', input)
.then(() => database.adapter.find('_Installation', installationSchema, {}, {}))
.then(results => {
expect(results.length).toEqual(1);
return rest.update(
config,
auth.nobody(config),
'_Installation',
{ objectId: results[0].objectId },
{ installationId: { foo: 'bar' } }
);
})
.then(() => {
fail('Updating the installation should have failed.');
done();
})
.catch(error => {
expect(error.code).toEqual(Parse.Error.INVALID_JSON);
done();
});
});

Comment on lines +605 to +684
it('master key cannot clear installationId via Delete op', done => {
const installId = '12345678-abcd-abcd-abcd-123456789abc';
const input = {
installationId: installId,
deviceType: 'ios',
};
rest
.create(config, auth.master(config), '_Installation', input)
.then(() => database.adapter.find('_Installation', installationSchema, {}, {}))
.then(results => {
expect(results.length).toEqual(1);
return rest.update(
config,
auth.master(config),
'_Installation',
{ objectId: results[0].objectId },
{ installationId: { __op: 'Delete' } }
);
})
.then(() => {
fail('Master key clearing of installationId should have been rejected.');
done();
})
.catch(error => {
expect(error.code).toEqual(136);
done();
});
Comment on lines +622 to +711
});

it('master key cannot clear installationId via null', done => {
const installId = '12345678-abcd-abcd-abcd-123456789abc';
const input = {
installationId: installId,
deviceType: 'ios',
};
rest
.create(config, auth.master(config), '_Installation', input)
.then(() => database.adapter.find('_Installation', installationSchema, {}, {}))
.then(results => {
expect(results.length).toEqual(1);
return rest.update(
config,
auth.master(config),
'_Installation',
{ objectId: results[0].objectId },
{ installationId: null }
);
})
.then(() => {
fail('Master key clearing of installationId via null should have been rejected.');
done();
})
.catch(error => {
expect(error.code).toEqual(136);
done();
});
});

Comment on lines +656 to +742
it('update fails to change deviceType', done => {
const installId = '12345678-abcd-abcd-abcd-123456789abc';
let input = {
Expand Down
33 changes: 33 additions & 0 deletions src/RestWrite.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1293,6 +1293,39 @@ RestWrite.prototype.handleInstallation = function () {
return;
}

// installationId is the row's primary identity (used by the SDK auth
// header to bind a client request to its row). Reject any attempt to
// clear it via null or { __op: 'Delete' } before the lookup logic
// below runs — { __op: 'Delete' } would otherwise crash on
// `.toLowerCase()` (TypeError → 500) and null would silently orphan
// the row. Mirrors the existing 136 guard against changing
// installationId from one value to another.
const clearingInstallationId =
this.data.installationId === null ||
(typeof this.data.installationId === 'object' &&
this.data.installationId !== null &&
this.data.installationId.__op === 'Delete');
Comment thread
AdrianCurtin marked this conversation as resolved.
if (clearingInstallationId) {
if (this.query) {
throw new Parse.Error(136, 'installationId may not be changed in this operation');
}
// Create path: drop the invalid value so the existing "must specify
// ID" guard below can run. If no alternative ID (deviceToken,
// auth.installationId) is supplied the create is rejected with
// error 135; otherwise the create proceeds with the remaining ID.
delete this.data.installationId;
}

// Any remaining non-string installationId (object, array, number, etc.)
// would crash on `.toLowerCase()` below; reject it as a Parse error
// rather than letting it surface as a 500.
if (
this.data.installationId !== undefined &&
typeof this.data.installationId !== 'string'
) {
throw new Parse.Error(Parse.Error.INVALID_JSON, 'installationId must be a string');
}
Comment on lines +1322 to +1327

if (
!this.query &&
!this.data.deviceToken &&
Expand Down