Conversation
Benchmark Size Comparison (vs main)
OK: All artifacts within 5% regression thresholdRun 22708133635 | a900bbc | 2026-03-05 08:25 UTC |
There was a problem hiding this comment.
Pull request overview
This pull request adds comprehensive end-to-end testing infrastructure and test contracts to the cargo-pvm-contract project. The PR introduces a new e2e testing crate, nine test contracts covering various scenarios, integration tests, and updates to code generation for proper handling of composite types in return values.
Changes:
- Adds
pvm-contract-e2e-testscrate with utilities for running anvil-polkadot nodes, building contracts, and interacting with the blockchain via cast - Introduces nine test contracts (flipper, storage-types, return-values, caller-check, error-handling, events, multi-method, dynamic-types, composite-types) with corresponding Solidity interfaces
- Updates dispatch code generation to correctly handle FixedArray and Tuple types in single return values, and adds special handling for DynBytes encoding
Reviewed changes
Copilot reviewed 34 out of 36 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/pvm-contract-e2e-tests/ | New testing infrastructure with anvil management, contract building, and cast client |
| crates/pvm-contract-e2e-tests/tests/ | Integration and E2E tests for contract functionality and build artifacts |
| examples/test-contracts/src/ | Nine new test contracts demonstrating various contract patterns |
| examples/test-contracts/*.sol | Solidity interface files for test contracts |
| examples/test-contracts/Cargo.toml | Build configuration for test contracts |
| crates/pvm-contract-macros/src/codegen/dispatch.rs | Fixed encoding for FixedArray/Tuple returns and DynBytes special handling |
| Cargo.toml | Added pvm-contract-e2e-tests to workspace |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pgherveou
reviewed
Feb 27, 2026
| }; | ||
|
|
||
| // totalSupply() -> uint256, view | ||
| let f = find_fn("totalSupply"); |
Collaborator
There was a problem hiding this comment.
all these asserts are quite verbose. I would just assert the whole things against a golden json file
| } | ||
|
|
||
| #[test] | ||
| #[ignore] |
Collaborator
There was a problem hiding this comment.
why do we ignore all the tests?
Collaborator
Author
There was a problem hiding this comment.
I assumed that use may not have the anvil-polkadot installed. Removed ignore
Comment on lines
+1
to
+2
| #![cfg_attr(not(feature = "abi-gen"), no_main)] | ||
| #![cfg_attr(not(feature = "abi-gen"), no_std)] |
Collaborator
There was a problem hiding this comment.
nit we should have the template generate that as
#![cfg_attr(not(feature = "abi-gen"), no_main, no_std)]
pgherveou
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.