Skip to content

Extract JavaScript backend test resources to files #23066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
riisi wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Extract JavaScript backend test resources to files #23066

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e15af6d
Extract JavaScript backend test resources to files
Feb 1, 2026
e3716f7
Trigger CI
Feb 1, 2026
6eb8948
Trigger CI
Feb 1, 2026
ddfa8dd
Consolidate JS backend test resources and improve organisation
Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/python/pants/backend/javascript/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,8 @@ python_sources()
python_tests(
name="tests",
)

resources(
name="test_resources",
sources=["test_resources/**/*"],
)
6 changes: 5 additions & 1 deletion src/python/pants/backend/javascript/goals/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,11 @@ python_tests(
# The package.json files are inlined in ./test_integration_tests.py
overrides={
"test_integration_test.py": {
"dependencies": ["./jest_resources", "./mocha_resources"],
"dependencies": [
"./jest_resources",
Copy link
Copy Markdown
Contributor

@benjyw benjyw Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my education: what is the distinction between these jest_resources and the ones under test_resources/jest_project?

"./mocha_resources",
"//src/python/pants/backend/javascript:test_resources",
],
"timeout": 240,
},
"export_test.py": {
Expand Down
Loading
Loading