[Update Stale] AWS S3 Setup for Drupal#10057
Draft
jazzsequence wants to merge 1 commit into
Draft
Conversation
|
Successfully created multidev environment: pr-10057 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AWS S3 Setup for Drupal⚠️
Date: 2016-09-01
Days since last review: 3527
Confidence rating: Low
Review notes
This document is nearly 9 years old (last reviewed 2016-09-01) and covers multiple third-party services and modules that have changed significantly:
AWS Console UI (lines 39–105): The AWS IAM console has been substantially redesigned since 2016. Steps like "Create your Own Policy" (line 65), "Add more permissions" (line 53), and "Create New Group" (line 83) no longer reflect the current AWS console UI. IAM Groups for new users now follows a different flow.
AWS SDK Library version (lines 135–143): The doc references AWS SDK Library 2.x, which is now ancient. The s3fs Drupal module has moved to requiring AWS SDK 3.x for many years.
Drush version guidance (lines 113–117): References to Drush 8 as default and "sites created prior to November 4, 2015 run 5.x" are extremely outdated. Drush 8 itself is end-of-life. Current Drupal sites on Pantheon use Drush 10/11/12 depending on Drupal version.
s3fs.make file / Drush make (lines 137–141):
drush makeis a Drush 8 feature that is not available in Drush 9+. The s3fs module now recommends Composer for dependency management.Libraries API module (line 129): For modern Drupal (8/9/10), the Libraries API module is not used; the AWS SDK is managed via Composer. Even for Drupal 7, this workflow has changed.
sites/default/default.settings.phpreference (line 118): Links todrops-7, implying this is Drupal 7 only — but the document title says "Drupal" generically, which is misleading given Pantheon now primarily supports Drupal 10/11.S3 File System CORS module (lines 147–153): The s3fs_cors module's status and compatibility should be verified; the
jquery_updatedependency referenced is also very dated.The sheer number of outdated references — spanning AWS console UI, Drush versions, SDK versions, and module management workflows — makes this document significantly inaccurate. More than 5 lines require changes.
Confidence: Low⚠️ — More than 5 lines require changes across AWS console UI steps, Drush version guidance, SDK version references, and Composer vs. drush-make workflows. Many of these involve third-party behavior (AWS console, Drupal modules, Drush) that cannot be fully verified against current state from training data alone.
Suggested resolution
Given the scope of changes required across AWS console UI steps, Drush version guidance, SDK version references, and module management workflows, a substantial rewrite or replacement is needed. Specific updates should include:
drush make/ AWS SDK 2.x instructions with Composer-based installation of the AWS SDK 3.x.Because more than 5 lines need to change and third-party (AWS console, Drupal module, Drush) behavior cannot be fully verified against current state, confidence is set to low. A subject-matter expert should audit and rewrite this document before republishing.