Skip to content

Fix break line @param #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ngocnhan-tran1996 wants to merge 1 commit into
base: develop
Choose a base branch
from
+5 −5
Open

Fix break line @param #274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion javapoet/src/main/java/com/palantir/javapoet/CodeWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ public void emitJavadocWithParameters(CodeBlock javadoc, Iterable<ParameterSpec>
builder.add("\n");
}
emitTagNewline = false;
builder.add("@param $L $L", parameterSpec.name(), parameterSpec.javadoc());
builder.add("@param $L $L\n", parameterSpec.name(), parameterSpec.javadoc());
}
}
emitJavadoc(builder.build());
Expand Down
8 changes: 4 additions & 4 deletions javapoet/src/test/java/com/palantir/javapoet/MethodSpecTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,10 +333,10 @@ private void getTaco(double money) {
public void withParameterJavaDoc() {
MethodSpec methodSpec = MethodSpec.methodBuilder("getTaco")
.addParameter(ParameterSpec.builder(TypeName.DOUBLE, "money")
.addJavadoc("the amount required to buy the taco.\n")
.addJavadoc("the amount required to buy the taco.")
.build())
.addParameter(ParameterSpec.builder(TypeName.INT, "count")
.addJavadoc("the number of Tacos to buy.\n")
.addJavadoc("the number of Tacos to buy.")
.build())
.addJavadoc("Gets the best Taco money can buy.\n")
.build();
Expand All @@ -358,10 +358,10 @@ void getTaco(double money, int count) {
public void withParameterJavaDocAndWithoutMethodJavadoc() {
MethodSpec methodSpec = MethodSpec.methodBuilder("getTaco")
.addParameter(ParameterSpec.builder(TypeName.DOUBLE, "money")
.addJavadoc("the amount required to buy the taco.\n")
.addJavadoc("the amount required to buy the taco.")
.build())
.addParameter(ParameterSpec.builder(TypeName.INT, "count")
.addJavadoc("the number of Tacos to buy.\n")
.addJavadoc("the number of Tacos to buy.")
.build())
.build();
assertThat(methodSpec.toString())
Expand Down